Skip to content

fix: Update old subdomain URLs to new path-based domains#22340

Merged
erezrokah merged 2 commits intofix/update-readme-domainsfrom
copilot/sub-pr-22319-again
Mar 23, 2026
Merged

fix: Update old subdomain URLs to new path-based domains#22340
erezrokah merged 2 commits intofix/update-readme-domainsfrom
copilot/sub-pr-22319-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 23, 2026

The previous URL migration PR incorrectly updated a test assertion in cli/cmd/infer_test.go to expect www.cloudquery.io/hub/plugins/..., but the error message is generated by the external plugin-pb-go dependency which still produces hub.cloudquery.io/plugins/..., causing TestInferRegistry to fail in CI.

  • cli/cmd/infer_test.go: Reverted the wantErrContains assertion back to https://hub.cloudquery.io/plugins/... to match the actual error emitted by plugin-pb-go

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

Copilot AI changed the title [WIP] Fix: Update old subdomain URLs to new path-based domains fix: Revert infer_test.go URL assertion to match plugin-pb-go output Mar 23, 2026
@erezrokah erezrokah changed the title fix: Revert infer_test.go URL assertion to match plugin-pb-go output fix: Update old subdomain URLs to new path-based domains Mar 23, 2026
@erezrokah erezrokah marked this pull request as ready for review March 23, 2026 17:56
@erezrokah erezrokah requested a review from a team as a code owner March 23, 2026 17:56
@erezrokah erezrokah requested review from Copilot and dcelasun and removed request for a team March 23, 2026 17:56
Copilot AI requested a review from erezrokah March 23, 2026 17:56
@erezrokah erezrokah merged commit c95609e into fix/update-readme-domains Mar 23, 2026
3 checks passed
@erezrokah erezrokah deleted the copilot/sub-pr-22319-again branch March 23, 2026 17:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CI test failure in the CLI by aligning a test assertion with the actual error message emitted by the external plugin-pb-go dependency (which still references the hub.cloudquery.io domain).

Changes:

  • Reverted the wantErrContains URL in TestInferRegistry to expect https://hub.cloudquery.io/plugins/... instead of https://www.cloudquery.io/hub/plugins/....

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants