Skip to content

Conversation

@marianogappa
Copy link
Contributor

Removes API calls against Cloud that were removed. Upgrades cloudquery-api-go & plugin-sdk to latest version, continues to compile & run syncs properly.

Screenshot 2025-12-11 at 15 27 18

⚠️ This shouldn't be merged until Platform syncs are running against platform-cli.

@marianogappa marianogappa requested a review from a team as a code owner December 11, 2025 11:30
@marianogappa marianogappa added the no automerge Block automatic merging label Dec 11, 2025
@disq
Copy link
Member

disq commented Dec 11, 2025

Some more to remove.

@marianogappa
Copy link
Contributor Author

Nobody merge yet 🤣 Well it's a chore so it wouldn't cause a release but still

@disq
Copy link
Member

disq commented Dec 11, 2025

Maybe convert to draft to avoid accidental button presses.

@erezrokah
Copy link
Member

erezrokah commented Dec 11, 2025

Nobody merge yet 🤣 Well it's a chore so it wouldn't cause a release but still

It's ok to merge it won't break anything. Even a release won't break anything since in order for platform syncs to use this we need a PR to update the CLI in the platform repo, and the platform repo doesn't use this version of CLI anymore

@marianogappa marianogappa removed the no automerge Block automatic merging label Dec 11, 2025
@marianogappa marianogappa merged commit 585b4f4 into main Dec 11, 2025
18 checks passed
@marianogappa marianogappa deleted the mariano/remove-cloud-api-reporting branch December 11, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants