Skip to content

chore: Replace all golang-cross images with maintained version#21062

Merged
przste-go merged 1 commit intomainfrom
golang-cross-bump
Jul 18, 2025
Merged

chore: Replace all golang-cross images with maintained version#21062
przste-go merged 1 commit intomainfrom
golang-cross-bump

Conversation

@przste-go
Copy link
Copy Markdown

This PR replaces cq golang-cross image with maintained version.

@przste-go przste-go requested review from a team and savme July 18, 2025 06:40
@cq-bot cq-bot added the area/ci label Jul 18, 2025
@przste-go przste-go changed the title chore: Replace all golang-cross images with mainatiner version chore: Replace all golang-cross images with maintained version Jul 18, 2025
@przste-go
Copy link
Copy Markdown
Author

I'm starting to think we can actually get rid of all of those images like in here: https://github.com/cloudquery/cloudquery-private/pull/8321/files. WDYT @murarustefaan @savme ? It seems that for source plugins we are only using them for fips which shouldn't be needed

@przste-go przste-go merged commit 85d4001 into main Jul 18, 2025
20 checks passed
@przste-go przste-go deleted the golang-cross-bump branch July 18, 2025 08:37
@erezrokah
Copy link
Copy Markdown
Member

I'm starting to think we can actually get rid of all of those images like in here: https://github.com/cloudquery/cloudquery-private/pull/8321/files. WDYT @murarustefaan @savme ? It seems that for source plugins we are only using them for fips which shouldn't be needed

If I recall correctly we needed the images in the validate FIPS workflows since the old way of enabling FIPS required CGO_ENABLED=1. Since we don't need CGO_ENABLED=1 anymore for FIPS plugins we can probably get rid of the images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants