Conversation
erezrokah
left a comment
There was a problem hiding this comment.
Added a few comments, I think the top level and spec comments could be relevant to other plugins
|
|
||
| Known supported databases: | ||
|
|
||
| - PostgreSQL > v10 |
There was a problem hiding this comment.
| - PostgreSQL > v10 | |
| - PostgreSQL with a version greater or equal to 11 |
Do we mean >= 11? Or v10.0.1 is supported too?
There was a problem hiding this comment.
I think v10.0.1 should be supported as well. at least per my quick check locally. I didn't use any new shiny primitives.
There was a problem hiding this comment.
I think the only reason we supported 10 is because of Aurora which now supports 11 cc @bernays
|
|
||
| ## PostgreSQL Spec | ||
|
|
||
| This is the top level spec used by PostgreSQL Destination Plugin. |
There was a problem hiding this comment.
When we write top level, what does it mean?
To me it means that the yaml file looks like this:
kind: destination
connection_string: <>
There was a problem hiding this comment.
we can maybe just omit the top level or even better just remove this line and go straight to the spec as it's a bit redundant. The user should be aware of our convention and that every plugin has a spec (it is mentioned in our main docs so no need to repeat that).
In any case it means the following:
kind: destination
spec:
name: postgresql
mode: overwrite
spec:
// goes here
connection_string: stuff..
Similar to here - https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/ there is no intro wording that this is a spec and we already have an intro about what is the postgresql destination plugin
|
|
||
| - PostgreSQL > v10 | ||
|
|
||
| ## PostgreSQL Spec |
There was a problem hiding this comment.
| ## PostgreSQL Spec | |
| ## Configuration |
Can we use configuration instead of spec?
There was a problem hiding this comment.
I think we need to be consistent with the configuration as we use spec (we went the k8s way so should be familiar to some users) so would rather leave as is.
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Add general and config docs for PostgreSQL destination.