Skip to content

chore: Remove deprecated terraform files#2040

Merged
yevgenypats merged 1 commit intomainfrom
chore/remove_deprecated_terraform
Sep 27, 2022
Merged

chore: Remove deprecated terraform files#2040
yevgenypats merged 1 commit intomainfrom
chore/remove_deprecated_terraform

Conversation

@yevgenypats
Copy link
Copy Markdown
Contributor

Those files are not used and it confuses first time contributors and/or users who looks for guidelines on how to build new plugins.

@erezrokah
Copy link
Copy Markdown
Member

Can we move the files to https://github.com/cloudquery/deployments (private repo) instead? It's quite useful to have all these examples for manual testing purposes

@yevgenypats
Copy link
Copy Markdown
Contributor Author

Im not really sure on the usefullness of that anymore but we can def backup this in the deployment repo. most of those are just copy paste from the terraform registry website .

Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, let's move it somewhere where we can still access it relatively easily if we need to. Even if they are mostly copy-paste from the terraform website, it can require some fine-tuning to set all the parameters properly.

@yevgenypats
Copy link
Copy Markdown
Contributor Author

@amanenk mind taking care of that?

@amanenk
Copy link
Copy Markdown
Contributor

amanenk commented Sep 27, 2022

@yevgenypats @hermanschaaf https://github.com/cloudquery/deployments/pull/43

@yevgenypats yevgenypats merged commit ed361b7 into main Sep 27, 2022
@yevgenypats yevgenypats deleted the chore/remove_deprecated_terraform branch September 27, 2022 12:18
@erezrokah
Copy link
Copy Markdown
Member

Even if they are mostly copy-paste from the terraform website, it can require some fine-tuning to set all the parameters properly.

Fine tuning is my experience too (mostly copy paste didn't work out of the box for me, so I need to take the full examples terraform registry has and trim it to what I wanted).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants