chore: Run tests in parallel, wait before read (S3)#19320
chore: Run tests in parallel, wait before read (S3)#19320kodiakhq[bot] merged 8 commits intomainfrom
Conversation
| t.Fatal(fmt.Errorf("failed to close client: %w", err)) | ||
| } | ||
|
|
||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
can we signal completion instead of waiting an arbitrary amount of time?
There was a problem hiding this comment.
But it has already been completed, code runs fine without the sleep if you're lucky (if S3 behaves well). This is to "unflake" the test. We could also mock S3 here, but that would probably go outside of the scope of this PR, which is to get the StreamingBatchWriter updates safely over the line.
There was a problem hiding this comment.
Got it! Totally makes sense to keep mocking out of scope of this PR.
Perhaps, something like assert.Eventually could be a better fit here? Feel free to disregard the suggestion and proceed with the merge, though
There was a problem hiding this comment.
Good tip, implemented in all three PRs. Can't do it in the file PR unfortunately, without changing the test concept.
Getting the S3 plugin ready for the StreamingBatchWriter update.
Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921