chore: Run tests in parallel, sync before read (file)#19317
Merged
kodiakhq[bot] merged 6 commits intomainfrom Oct 7, 2024
Merged
chore: Run tests in parallel, sync before read (file)#19317kodiakhq[bot] merged 6 commits intomainfrom
kodiakhq[bot] merged 6 commits intomainfrom
Conversation
disq
commented
Oct 3, 2024
disq
commented
Oct 3, 2024
disq
commented
Oct 5, 2024
| name := c.spec.ReplacePathVariables(table.Name, uuid.NewString(), time.Time{}) | ||
|
|
||
| if syncAfterWrite { | ||
| time.Sleep(500 * time.Millisecond) |
Member
Author
There was a problem hiding this comment.
I've used assert.EventuallyWithT in the cloud storage destinations (gcs/azblob/S3) but here we use the TestInsert functionality from the SDK (testPlugin - except for parquet type or compressed formats) and it needs to be able to see the rows immediately after the write call. For parquet or compressed formats, we use testPluginCustom which follows the write / close / read pattern.
murarustefaan
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the file plugin ready for the StreamingBatchWriter update.
Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921