chore: Skip sending events for internal teams#18974
Merged
kodiakhq[bot] merged 7 commits intomainfrom Aug 22, 2024
Merged
Conversation
marianogappa
approved these changes
Aug 22, 2024
cli/internal/analytics/client.go
Outdated
| environment string | ||
| user cqapi.User | ||
| currentTeam string | ||
| currentTeamInternal bool |
Contributor
There was a problem hiding this comment.
I would call this isCurrentTeamInternal. It's just clearer what it is when the type is not immediately visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This skips emitting events if the team is marked internal. To do this we have to fetch the team internal flag on login and store it in the configuration.
Needs cloudquery/cloudquery-api-go#224