chore: Logging msg first letter captialized#1150
Closed
Nightfurex wants to merge 1 commit intocloudquery:mainfrom
Closed
chore: Logging msg first letter captialized#1150Nightfurex wants to merge 1 commit intocloudquery:mainfrom
Nightfurex wants to merge 1 commit intocloudquery:mainfrom
Conversation
Contributor
|
Hi @Nightfurex Thanks for your contributions! We are currently working on quite a few improvement for logging so this is why this blocked right now. |
Closed
Contributor
|
Closing this as we are in the mid of re-writing cloudquery and opened an issue - #1270 Thanks for bringing this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)