fix: Request correct config format (YAML) from provider#968
Merged
disq merged 3 commits intocloudquery:mainfrom Jun 22, 2022
Merged
fix: Request correct config format (YAML) from provider#968disq merged 3 commits intocloudquery:mainfrom
disq merged 3 commits intocloudquery:mainfrom
Conversation
26492d1 to
2a46cd7
Compare
erezrokah
approved these changes
Jun 21, 2022
erezrokah
reviewed
Jun 21, 2022
erezrokah
approved these changes
Jun 21, 2022
roneli
approved these changes
Jun 22, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
LGTM. I guess, maybe, add a test to the parser?
Member
I can follow up with another PR with tests as I added some in https://github.com/cloudquery/cloudquery/pull/969/files#diff-0f1a4fd4caa8778f443d8cb2b88e52020357ceac4ba0302c6d844aa784bf36e7R112 |
Member
Author
|
Yeah I'll merge this and we'll follow up with tests later |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
🤖 I have created a release *beep* *boop* --- ## [0.27.0](v0.26.4...v0.27.0) (2022-06-22) ### ⚠ BREAKING CHANGES * Remove drift (#887) ### Features * Remove drift ([#887](#887)) ([3d387bd](3d387bd)) * Add YAML configuration support ([#887](#887)) ([3d387bd](3d387bd)) ### Bug Fixes * Default alias to name ([#966](#966)) ([706447c](706447c)) * Support modules tag in config ([#965](#965)) ([379344f](379344f)) * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.12.1 ([#972](#972)) ([1f871e9](1f871e9)) * Request correct config format (YAML) from provider ([#968](#968)) ([999b68d](999b68d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise ConfigureProvider is called with no format, which would default to HCL.
init/config providers format also moved from map to list of providers.