feat(gcp-resources): Add vision#6786
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jan 13, 2023
shimonp21:feat_gcp_vision
Merged
feat(gcp-resources): Add vision#6786kodiakhq[bot] merged 2 commits intocloudquery:mainfrom shimonp21:feat_gcp_vision
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
shimonp21:feat_gcp_vision
Conversation
This PR has the following changes to source plugin(s) tables:
|
erezrokah
approved these changes
Jan 13, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks great, we can remove one code comment I think. I like the usage of a multiplexer here and will port
once this is merged
plugins/source/gcp/resources/services/vision/reference_image.go
Outdated
Show resolved
Hide resolved
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 15, 2023
#### Summary Follow up to #6786. We should add the location to the client ID as it has to be unique <!--
erezrokah
pushed a commit
that referenced
this pull request
Jan 17, 2023
🤖 I have created a release *beep* *boop* --- ## [7.2.0](plugins-source-gcp-v7.1.1...plugins-source-gcp-v7.2.0) (2023-01-17) ### Features * Add GCP vmmigration ([#6760](#6760)) ([28d9825](28d9825)) * ADD GCP VPC Access ([#6755](#6755)) ([59c32dc](59c32dc)) * Add GCP Web Security Scanner ([#6674](#6674)) ([9b08d0e](9b08d0e)) * **gcp-resources:** Add Cloud Scheduler ([#6770](#6770)) ([b0941af](b0941af)) * **gcp-resources:** Add Cloud Support ([#6771](#6771)) ([7aefc2b](7aefc2b)) * **gcp-resources:** Add livestream ([#6788](#6788)) ([6da9658](6da9658)) * **gcp-resources:** Add missing KMS resources ([#6769](#6769)) ([9ecc4d7](9ecc4d7)) * **gcp-resources:** Add translate ([#6832](#6832)) ([d827029](d827029)) * **gcp-resources:** Add video-transcoder ([#6806](#6806)) ([d4fd41d](d4fd41d)) * **gcp-resources:** Add vision ([#6786](#6786)) ([3dd6116](3dd6116)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.2 ([#6695](#6695)) ([694ab9f](694ab9f)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.0 ([#6745](#6745)) ([9c41854](9c41854)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.1 ([#6805](#6805)) ([9da0ce2](9da0ce2)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.26.0 ([#6839](#6839)) ([6ccda8d](6ccda8d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.27.0 ([#6856](#6856)) ([545799b](545799b)) * **gcp:** Add `Location` to client `ID` when present ([#6807](#6807)) ([8b21b80](8b21b80)) * **gcp:** Prevent gcp_resourcemanager_folders rows with nil org_id ([#6577](#6577)) ([266c191](266c191)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caveats: