Skip to content

feat(slack): Migrate codegen to transformations#6471

Merged
kodiakhq[bot] merged 11 commits intomainfrom
feat/slack_migration_codegenless
Jan 9, 2023
Merged

feat(slack): Migrate codegen to transformations#6471
kodiakhq[bot] merged 11 commits intomainfrom
feat/slack_migration_codegenless

Conversation

@yevgenypats
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats commented Jan 7, 2023

No description provided.

@yevgenypats yevgenypats requested review from a team and shimonp21 and removed request for a team January 7, 2023 14:45
@cq-bot cq-bot added the slack label Jan 7, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2023 •
edited
Loading

This PR has the following changes to source plugin(s) tables:

  • Table slack_conversation_bookmarks: column order changed for date_created
  • Table slack_conversation_bookmarks: column order changed for date_updated
  • Table slack_conversation_histories: column added with name channel and type String
  • Table slack_conversation_histories: column added with name team and type String
  • Table slack_conversation_histories: column order changed for thread_ts
  • Table slack_conversation_histories: column order changed for ts
  • Table slack_conversation_replies: column added with name team and type String
  • Table slack_conversation_replies: column order changed for ts
  • Table slack_user_presences: column order changed for connection_count
  • Table slack_user_presences: column order changed for last_activity
  • Table slack_users: column order changed for updated

@yevgenypats yevgenypats requested review from hermanschaaf and removed request for shimonp21 January 8, 2023 11:05
hermanschaaf
hermanschaaf approved these changes Jan 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I'll fix the service interface generation bit in a follow-up after we merge

@hermanschaaf
Copy link
Copy Markdown
Contributor

hermanschaaf commented Jan 9, 2023

Oh wait, there are some added columns that should remain skipped because the API doesn't actually ever return them, so it's confusing to keep them there

@hermanschaaf
Copy link
Copy Markdown
Contributor

hermanschaaf commented Jan 9, 2023

The two columns are has_2fa and presence

@yevgenypats yevgenypats added the automerge Automatically merge once required checks pass label Jan 9, 2023
@yevgenypats yevgenypats removed the automerge Automatically merge once required checks pass label Jan 9, 2023
@hermanschaaf hermanschaaf added the automerge Automatically merge once required checks pass label Jan 9, 2023
@kodiakhq kodiakhq bot merged commit 5fb3f72 into main Jan 9, 2023
@kodiakhq kodiakhq bot deleted the feat/slack_migration_codegenless branch January 9, 2023 17:19
@cq-bot cq-bot mentioned this pull request Jan 9, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Jan 10, 2023
@cq-bot
chore(main): Release plugins-source-slack v1.1.0 (#6288)
eaa5b5f 
🤖 I have created a release *beep* *boop*
---


## [1.1.0](plugins-source-slack-v1.0.2...plugins-source-slack-v1.1.0) (2023-01-10)


### Features

* **slack:** Migrate codegen to transformations ([#6471](#6471)) ([5fb3f72](5fb3f72))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.17.2 ([#6260](#6260)) ([805972a](805972a))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([#6553](#6553)) ([392b848](392b848))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hermanschaaf hermanschaaf hermanschaaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yevgenypats @hermanschaaf @cq-bot