feat(postgresql): Update pgx to v5#5757
Merged
kodiakhq[bot] merged 4 commits intomainfrom Dec 18, 2022
Merged
Conversation
erezrokah
approved these changes
Dec 18, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good overall. Let's merge this so we can battle test is on main
| } | ||
| atomic.AddUint64(&c.metrics.Errors, 1) | ||
| c.logger.Error().Err(pgErr).Str("table", pgErr.TableName).Msg("failed to execute batch with pgerror") | ||
| return fmt.Errorf("failed to execute batch with pgerror on table %s: %w", pgErr.TableName, err) |
Member
There was a problem hiding this comment.
Since this stops the sync (correct me if I'm wrong), maybe add a call to action?
Try skipping this table via 'skip_tables: ["<table_name>"]' and re-running the sync command
Contributor
Author
There was a problem hiding this comment.
I think no need, better we get the report and fix it asap. This is basically equivalent of panic, it shouldn't happen mostly as validation should happen in our type system.
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
🤖 I have created a release *beep* *boop* --- ## [1.9.0](plugins-destination-postgresql-v1.8.0...plugins-destination-postgresql-v1.9.0) (2022-12-20) ### Features * **postgresql:** Update pgx to v5 ([#5757](#5757)) ([ce2aaf5](ce2aaf5)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.2 ([#5583](#5583)) ([d721c4e](d721c4e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.3 ([#5639](#5639)) ([6452d0e](6452d0e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.4 ([#5649](#5649)) ([b4aa889](b4aa889)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.5 ([#5661](#5661)) ([b354b8a](b354b8a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.6 ([#5790](#5790)) ([8e2663c](8e2663c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.7 ([#5797](#5797)) ([15da529](15da529)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #5733 (see discussion there). and needed so we can incorporate this nice bit: jackc/pgx#1441
The jackc/pgx#1441 is not a pre-requirement for this to go through. even better we should prob ship this first and see that
v5works for us and for our users and if not we can do the same fix forv4(we will just have to fork it as I don't thinkv4accepts anymore contributions)