feat(tailscale): Tailscale Source plugin#5546
Merged
Conversation
This PR has the following changes to source plugin(s) tables:
|
1def760 to
cc067d8
Compare
hermanschaaf
previously requested changes
Dec 12, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Looks great! I left a few minor comments, and I think we still need to follow some of the steps in this document for it to be released: https://github.com/cloudquery/cloudquery/blob/main/contributing/adding_a_new_plugin_to_cq_monorepo.md
a86acc2 to
d41655e
Compare
d9f2fc1 to
b7bb1d6
Compare
9dd53fc to
32d2108
Compare
bbernays
reviewed
Dec 12, 2022
bbernays
reviewed
Dec 12, 2022
51a7792 to
3ebbb04
Compare
yevgenypats
suggested changes
Dec 13, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Nice! Looks good and I like the tests with http instead of mocking.
Few minor comments:
- Makefile: remove
install-toolsandpre-commitas it's deprecated - Why
interface.gois needed? I don't think you need it and can use the specific tailscale.Client type.
yevgenypats
approved these changes
Dec 13, 2022
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
05e2150 to
e982326
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2022-12-15) ### Features * **tailscale:** Tailscale Source plugin ([#5546](#5546)) ([40df08b](40df08b)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.3 ([#5639](#5639)) ([6452d0e](6452d0e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.4 ([#5649](#5649)) ([b4aa889](b4aa889)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.5 ([#5661](#5661)) ([b354b8a](b354b8a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #5507
Summary