feat(gcp): Fetch Only enabled services#5534
Merged
kodiakhq[bot] merged 43 commits intocloudquery:mainfrom Dec 22, 2022
Merged
Conversation
yevgenypats
suggested changes
Dec 21, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
LGTM. two minor comments.
| package client | ||
|
|
||
| var GcpServices = map[string]bool{ | ||
| "apikeys.googleapis.com": true, |
Contributor
There was a problem hiding this comment.
Can we make those consts and then add this to the array. Similar how this is done https://github.com/cloudquery/cloudquery/blob/main/plugins/source/azure/client/namespaces.go
Collaborator
Author
There was a problem hiding this comment.
I don't think that const would make any sort of improvement because we are still just dealing with strings in the codegen recipes...
In a future PR I would like to autogenerate this whole map like we do with the AWS data json file
yevgenypats
approved these changes
Dec 22, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 27, 2022
🤖 I have created a release *beep* *boop* --- ## [5.3.0](plugins-source-gcp-v5.2.0...plugins-source-gcp-v5.3.0) (2022-12-27) ### Features * **gcp:** Fetch Only enabled services ([#5534](#5534)) ([667b567](667b567)) * **resources:** Add API Gateway ([#5926](#5926)) ([7bb33a8](7bb33a8)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.13.1 ([#5897](#5897)) ([ad15915](ad15915)) * **gcp:** List locations before getting run services ([#5919](#5919)) ([7581466](7581466)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 28, 2022
#### Summary Follow up to #5534. In most cases `ServiceDNS` can be inferred from `Service` (not sure but we might want to update `Service` when it doesn't) <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client.ProjectMultiplexEnabledServices