feat(aws): Add ssoadmin permission_sets, account_assignments#4817
Merged
kodiakhq[bot] merged 12 commits intocloudquery:mainfrom Nov 23, 2022
Merged
feat(aws): Add ssoadmin permission_sets, account_assignments#4817kodiakhq[bot] merged 12 commits intocloudquery:mainfrom
kodiakhq[bot] merged 12 commits intocloudquery:mainfrom
Conversation
bbernays
previously requested changes
Nov 20, 2022
Collaborator
bbernays
left a comment
There was a problem hiding this comment.
This looks good can you run:
make lint: to run the standard linting tool over the pluginmake gen-docs: to regenerate all of the docs for the plugin
plugins/source/aws/resources/services/ssoadmin/account_assignments_fetch.go
Outdated
Show resolved
Hide resolved
plugins/source/aws/resources/services/ssoadmin/permission_sets_fetch.go
Outdated
Show resolved
Hide resolved
…_fetch.go Co-authored-by: First Last <ben@bernays.me>
…ents_fetch.go Co-authored-by: First Last <ben@bernays.me>
bbernays
approved these changes
Nov 21, 2022
disq
requested changes
Nov 21, 2022
Member
disq
left a comment
There was a problem hiding this comment.
Thanks for the submission! I think I would prefer Descriptions to be linked to type descriptions rather than the actual API calls that were used to extract them. Just for consistency and ease of use.
Co-authored-by: Kemal <223029+disq@users.noreply.github.com>
Contributor
Author
|
I committed @disq suggestions but |
disq
approved these changes
Nov 22, 2022
Member
disq
left a comment
There was a problem hiding this comment.
LGTM, not sure about the gen-docs issue
Contributor
Author
|
Figured it out from the pipeline failures. I had to run |
hermanschaaf
approved these changes
Nov 23, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
🤖 I have created a release *beep* *boop* --- ## [7.2.0](plugins-source-aws-v7.1.4...plugins-source-aws-v7.2.0) (2022-11-23) ### Features * Add support for AWS Step Functions ([#4832](#4832)) ([08892a7](08892a7)) * **aws:** Add ssoadmin permission_sets, account_assignments ([#4817](#4817)) ([4ae00ca](4ae00ca)) * **aws:** Add Support for Cloudwatch Logs Resource Policy ([#4883](#4883)) ([84cb081](84cb081)) * **aws:** Validate Service Multiplexer ([#4882](#4882)) ([9619722](9619722)) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.3 ([#4943](#4943)) ([e4aaf3f](e4aaf3f)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.42 ([#4945](#4945)) ([e76c57d](e76c57d)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/accessanalyzer to v1.17.3 ([#4946](#4946)) ([fbf128e](fbf128e)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/acm to v1.16.3 ([#4947](#4947)) ([fde1bdf](fde1bdf)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigateway to v1.15.25 ([#4948](#4948)) ([7ceee4a](7ceee4a)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigatewayv2 to v1.12.23 ([#4949](#4949)) ([0edf753](0edf753)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/applicationautoscaling to v1.15.23 ([#4952](#4952)) ([c9fb1fd](c9fb1fd)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/autoscaling to v1.24.3 ([#4953](#4953)) ([b3478bf](b3478bf)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudformation to v1.24.1 ([#4954](#4954)) ([55800f6](55800f6)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudtrail to v1.20.3 ([#4955](#4955)) ([3c27da6](3c27da6)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatch to v1.21.11 ([#4956](#4956)) ([b9213b3](b9213b3)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.16.4 ([#4957](#4957)) ([c1a3791](c1a3791)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/configservice to v1.27.5 ([#4958](#4958)) ([2ab12d8](2ab12d8)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/databasemigrationservice to v1.22.1 ([#4959](#4959)) ([85d4d39](85d4d39)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.72.1 ([#4950](#4950)) ([b3dea9a](b3dea9a)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecr to v1.17.23 ([#4951](#4951)) ([731ff3d](731ff3d)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing to v1.14.23 ([#4960](#4960)) ([93babd5](93babd5)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 to v1.18.26 ([#4961](#4961)) ([465c9b7](465c9b7)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticsearchservice to v1.17.2 ([#4962](#4962)) ([aa231c6](aa231c6)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/emr to v1.20.16 ([#4963](#4963)) ([5964e7c](5964e7c)) * **deps:** Update plugin-sdk for aws to v1.8.0 ([#4966](#4966)) ([16817f4](16817f4)) * Update endpoints ([#4939](#4939)) ([c09f7b1](c09f7b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for SSOAdmin permission sets
Add support for SSOAdmin account assignments