fix: Improve AWS credentials error message and local profile docs#4708
Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom Nov 16, 2022
Merged
fix: Improve AWS credentials error message and local profile docs#4708kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
Conversation
erezrokah
commented
Nov 16, 2022
plugins/source/aws/client/client.go
Outdated
| if _, err := awsCfg.Credentials.Retrieve(ctx); err != nil { | ||
| logger.Error().Err(err).Msg("error retrieving credentials") | ||
| return awsCfg, fmt.Errorf("error retrieving credentials: %w", err) | ||
| return awsCfg, fmt.Errorf("error retrieving AWS credentials. Please verify your credentials and try again") |
Member
Author
There was a problem hiding this comment.
The full AWS error is still in the logs
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
hermanschaaf
approved these changes
Nov 16, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
LGTM 👍 Just one more suggestion, but not a blocker
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.1](plugins-source-aws-v7.0.0...plugins-source-aws-v7.0.1) (2022-11-16) ### Bug Fixes * Improve AWS credentials error message and local profile docs ([#4708](#4708)) ([2a159b8](2a159b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4656