feat: Update all plugins to SDK with metrics and DFS scheduler#3286
Merged
kodiakhq[bot] merged 16 commits intomainfrom Oct 30, 2022
Merged
feat: Update all plugins to SDK with metrics and DFS scheduler#3286kodiakhq[bot] merged 16 commits intomainfrom
kodiakhq[bot] merged 16 commits intomainfrom
Conversation
erezrokah
approved these changes
Oct 30, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
This looks 🚀 Added a few non blocking comments.
I'm assuming this needs to come with a separate PR for the CLI to call GetMetrics? Are we planning to release the CLI first, then plugins or the other way around?
|
|
||
| output, err := svc.DescribeGlobalSettings(ctx, &input) | ||
| if err != nil { | ||
| if client.IgnoreAccessDeniedServiceDisabled(err) || client.IsAWSError(err, "ERROR_9601") /* "Your account is not a member of an organization" */ { |
Member
There was a problem hiding this comment.
How about we keep this change (and other removals of log messages/errors) to a separate PR.
Basically only do the meta.Logger() -> meta.(*client.Client).Logger() changes to keep the size of the PR small?
We can do a follow up to look into the error handling in various AWS resources and see how we want to handle them? I agree that it looks like we can remove most of them, but I can't be sure for a few
Contributor
Author
There was a problem hiding this comment.
I think it's a nit, it's already split. Let's keep like this and address other issue with AWS later on with unneeded/un-normalized log messages and so on.
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
This was referenced Oct 30, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-source-github-v1.0.9...plugins-source-github-v1.1.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-source-azure-v1.0.10...plugins-source-azure-v1.1.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-source-terraform-v1.0.10...plugins-source-terraform-v1.1.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [1.4.0](plugins-destination-postgresql-v1.3.11...plugins-destination-postgresql-v1.4.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [3.8.0](plugins-source-aws-v3.7.0...plugins-source-aws-v3.8.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-source-okta-v1.0.11...plugins-source-okta-v1.1.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [2.1.0](plugins-source-heroku-v2.0.7...plugins-source-heroku-v2.1.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [2.1.0](plugins-source-cloudflare-v2.0.8...plugins-source-cloudflare-v2.1.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](plugins-source-test-v1.2.8...plugins-source-test-v1.3.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](plugins-source-gcp-v2.2.2...plugins-source-gcp-v2.3.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [2.2.0](plugins-source-k8s-v2.1.2...plugins-source-k8s-v2.2.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
🤖 I have created a release *beep* *boop* --- ## [2.1.0](plugins-source-digitalocean-v2.0.8...plugins-source-digitalocean-v2.1.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](#3286)) ([a35b8e8](a35b8e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
yevgenypats
added a commit
that referenced
this pull request
Nov 1, 2022
This is instead of #3176 SDK PRs: cloudquery/plugin-sdk#318 cloudquery/plugin-sdk#320 Previous related CloudQuery PRs: #3286 Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
yevgenypats
added a commit
that referenced
this pull request
Nov 1, 2022
This is instead of #3176 SDK PRs: cloudquery/plugin-sdk#318 cloudquery/plugin-sdk#320 Previous related CloudQuery PRs: #3286 Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
daniel-garcia
pushed a commit
to infobloxopen/ibcq-source-k8s
that referenced
this pull request
Feb 24, 2026
🤖 I have created a release *beep* *boop* --- ## [2.2.0](cloudquery/cloudquery@plugins-source-k8s-v2.1.2...plugins-source-k8s-v2.2.0) (2022-10-31) ### Features * Update all plugins to SDK with metrics and DFS scheduler ([#3286](cloudquery/cloudquery#3286)) ([fff38f8](cloudquery/cloudquery@fff38f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
daniel-garcia
pushed a commit
to infobloxopen/ibcq-source-k8s
that referenced
this pull request
Feb 24, 2026
This is instead of cloudquery/cloudquery#3176 SDK PRs: cloudquery/plugin-sdk#318 cloudquery/plugin-sdk#320 Previous related CloudQuery PRs: cloudquery/cloudquery#3286 Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged after this SDK PR cloudquery/plugin-sdk#318