fix: Filtering for DocDB + Neptune#3271
Merged
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom Nov 1, 2022
Merged
Conversation
erezrokah
approved these changes
Oct 30, 2022
disq
approved these changes
Oct 31, 2022
yevgenypats
approved these changes
Oct 31, 2022
Contributor
|
Looks good. will wait for this to go through #3323 and we can rebase and merge |
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-source-aws-v3.8.0...plugins-source-aws-v4.0.0) (2022-11-02) ### ⚠ BREAKING CHANGES * **aws:** Unified tag structure (#3330) ### Features * Add eventbridge resources ([#3160](#3160)) ([67d3a35](67d3a35)) * **aws:** Fraud Detector support ([#3076](#3076)) ([f0e309a](f0e309a)) * Migrate cli, plugins and destinations to new type system ([#3323](#3323)) ([f265a94](f265a94)) * Update AWS Services (new fields) ([#3324](#3324)) ([0b65803](0b65803)) ### Bug Fixes * Add id to aws_cloudfront_cache_policies, region to aws_ec2_transit_gateways ([#3444](#3444)) ([41362e2](41362e2)) * **aws:** Unified tag structure ([#3330](#3330)) ([c9c1e4c](c9c1e4c)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/credentials to v1.12.23 ([#3378](#3378)) ([c33bf73](c33bf73)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.37 ([#3379](#3379)) ([3f1a71d](3f1a71d)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/acm to v1.15.2 ([#3380](#3380)) ([b4329ee](b4329ee)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigateway to v1.15.22 ([#3381](#3381)) ([5816480](5816480)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigatewayv2 to v1.12.20 ([#3385](#3385)) ([2dd39a6](2dd39a6)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/applicationautoscaling to v1.15.20 ([#3386](#3386)) ([0702717](0702717)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/appsync to v1.15.12 ([#3387](#3387)) ([6bb936a](6bb936a)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/athena to v1.18.12 ([#3388](#3388)) ([e95f748](e95f748)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/autoscaling to v1.23.18 ([#3389](#3389)) ([5af977f](5af977f)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/backup to v1.17.11 ([#3390](#3390)) ([1ecaab7](1ecaab7)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudfront to v1.20.7 ([#3391](#3391)) ([46465d1](46465d1)) * **deps:** Update plugin-sdk for aws to v0.13.17 ([#3399](#3399)) ([f2cd266](f2cd266)) * **deps:** Update plugin-sdk for aws to v0.13.18 ([#3409](#3409)) ([92fa576](92fa576)) * Filtering for DocDB + Neptune ([#3271](#3271)) ([8080c6e](8080c6e)) * Update endpoints ([#3368](#3368)) ([b78c6b1](b78c6b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocDB + Neptune seem to be wrappers around RDS APIs and they return data about all engine types. This change filters those results so that for DocDB and Neptune only resources pertaining to those services show up
Thank you to @Barneyjm for finding this