feat(aws): Use PreResourceResolver when necessary, remove ListAndDetailResolver#2460
Merged
kodiakhq[bot] merged 17 commits intocloudquery:mainfrom Oct 12, 2022
Merged
Conversation
0df8cb5 to
10b1b05
Compare
Contributor
|
This should go in with cloudquery/plugin-sdk#268 |
yevgenypats
approved these changes
Oct 10, 2022
fa2f3a0 to
b8e34f6
Compare
Member
Author
|
Now waiting for #2661 |
b8e34f6 to
af1fc5a
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](plugins-source-aws-v2.2.0...plugins-source-aws-v2.3.0) (2022-10-12) ### Features * **aws:** Use PreResourceResolver when necessary, remove ListAndDetailResolver ([#2460](#2460)) ([340f614](340f614)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More here #2461
BEWARE merging this before updating the plugin-sdk for "PreResourceResolver parallelism" will cause performance regressions. (#2461 doesn't have that issue, as those resources are already linear)