feat: Add DeleteRecord handling to SQLite destination#21102
feat: Add DeleteRecord handling to SQLite destination#21102kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
Conversation
hermanschaaf
left a comment
There was a problem hiding this comment.
Thanks for the pull request @jeromewir! We'll review this a bit more closely, I just left one comment for now after a quick read through. Also, I changed the title from feat! to feat because I think this isn't a breaking change, right?
| continue | ||
| } | ||
| sb.WriteString("(") | ||
| for i, predicate := range predicateGroup.Predicates { |
There was a problem hiding this comment.
This inner loop is re-using i as an index variable which should work, I think, due to how variables can be shadowed in Go, but I would say is not recommended, mostly for readability reasons.
Oh, I didn't realize the I just added a missing folder |
🤖 I have created a release *beep* *boop* --- ## [2.11.0](plugins-destination-sqlite-v2.10.22...plugins-destination-sqlite-v2.11.0) (2025-07-24) ### Features * Add DeleteRecord handling to SQLite destination ([#21102](#21102)) ([e1bf276](e1bf276)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.87.3 ([#21010](#21010)) ([c78cff9](c78cff9)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.87.4 ([#21104](#21104)) ([44f77c8](44f77c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
#### Summary Following up on #21102 There was a leftover from the debugging session that got merged into the release. This removes a `fmt.Println(...)` left in the `unpackArray` function from the SQLite plugin, used when sending DeleteRecord messages.
Summary
Following up on https://community.cloudquery.io/t/incremental-tables-how-to-handle-deletion/1205/6
This PR adds support for
DeleteRecordmessages so sources can specify which items can be deleted specifically.I used a lot of the existing code present in the ClickHouse PR: https://github.com/cloudquery/cloudquery/pull/20772/files