Skip to content

feat: Support different formats for time variables#20626

Merged
kodiakhq[bot] merged 3 commits intomainfrom
feature/eng-975-featcli-support-different-formats-for-time-variables
Apr 28, 2025
Merged

feat: Support different formats for time variables#20626
kodiakhq[bot] merged 3 commits intomainfrom
feature/eng-975-featcli-support-different-formats-for-time-variables

Conversation

@przste-go
Copy link
Copy Markdown

Summary

⚠️ If you're contributing to a plugin please read this section of the contribution guidelines 🧑‍🎓 before submitting this PR ⚠️

This PR follows changes introduced in #20399. In enables formatting substituted times using '|' operator according to golang time layout spec https://go.dev/src/time/format.go.

@przste-go przste-go marked this pull request as ready for review April 28, 2025 08:11
@przste-go przste-go requested review from a team and maaarcelino April 28, 2025 08:11
Copy link
Copy Markdown
Contributor

@maaarcelino maaarcelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@przste-go przste-go added automerge Automatically merge once required checks pass and removed automerge Automatically merge once required checks pass labels Apr 28, 2025
@przste-go przste-go added the automerge Automatically merge once required checks pass label Apr 28, 2025
@erezrokah
Copy link
Copy Markdown
Member

@przste-go
Copy link
Copy Markdown
Author

Nice 🚀 Can we also update https://github.com/cloudquery/frontend/blob/bcfadbebee70701eea8412877cdc1f161c3e5047/apps/docs/pages/docs/advanced-topics/environment-variable-substitution.md#time-variable-substitution-example?

@erezrokah Yes, I'm doing it right atm 🚀

@przste-go
Copy link
Copy Markdown
Author

@kodiakhq kodiakhq bot merged commit 4242ce5 into main Apr 28, 2025
18 checks passed
@kodiakhq kodiakhq bot deleted the feature/eng-975-featcli-support-different-formats-for-time-variables branch April 28, 2025 10:11
kodiakhq bot pushed a commit that referenced this pull request Apr 28, 2025
🤖 I have created a release *beep* *boop*
---


## [6.18.0](cli-v6.17.6...cli-v6.18.0) (2025-04-28)


### Features

* Support different formats for time variables ([#20626](#20626)) ([4242ce5](4242ce5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants