fix: Don't print skip download message to console#2008
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Sep 23, 2022
Merged
fix: Don't print skip download message to console#2008kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
Contributor
|
I'll leave this to @yevgenypats to approve, but seems fair enough to me to leave this message for the logs. |
yevgenypats
approved these changes
Sep 23, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 25, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.0-pre.0](cli-v0.33.4-pre.0...cli-v1.0.0-pre.0) (2022-09-25) ### ⚠ BREAKING CHANGES * **cli:** Remove gen command (#2022) ### Features * **cli:** Remove gen command ([#2022](#2022)) ([83a32dd](83a32dd)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.0 ([#1997](#1997)) ([4fa40da](4fa40da)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.1 ([#2024](#2024)) ([8f88de4](8f88de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.2 ([#2044](#2044)) ([9b69b46](9b69b46)) * Don't print skip download message to console ([#2008](#2008)) ([a947d44](a947d44)) * Use uppercase downloading during progress ([#2006](#2006)) ([e6a7a44](e6a7a44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
yevgenypats
pushed a commit
that referenced
this pull request
Sep 26, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.0-pre.0](cli-v0.33.4-pre.0...cli-v1.0.0-pre.0) (2022-09-25) ### ⚠ BREAKING CHANGES * **cli:** Remove gen command (#2022) ### Features * **cli:** Remove gen command ([#2022](#2022)) ([83a32dd](83a32dd)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.0 ([#1997](#1997)) ([4fa40da](4fa40da)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.1 ([#2024](#2024)) ([8f88de4](8f88de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.2 ([#2044](#2044)) ([9b69b46](9b69b46)) * Don't print skip download message to console ([#2008](#2008)) ([a947d44](a947d44)) * Use uppercase downloading during progress ([#2006](#2006)) ([e6a7a44](e6a7a44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
yevgenypats
added a commit
that referenced
this pull request
Sep 26, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.0-pre.1](cli-v1.1.0-pre.0...cli-v1.1.0-pre.1) (2022-09-26) ### ⚠ BREAKING CHANGES * **cli:** Remove gen command (#2022) * CloudQuery V1. (#1463) ### Features * **cli:** Disable sentry in development ([#1939](#1939)) ([e2c417e](e2c417e)) * **cli:** Remove gen command ([#2022](#2022)) ([83a32dd](83a32dd)) * CloudQuery V2. ([#1463](#1463)) ([d1799f3](d1799f3)) * Create directory structure when generating configuration ([#1845](#1845)) ([4f9c8de](4f9c8de)) * **gcp:** Remove Classify and IgnoreError ([#1757](#1757)) ([3d34ca5](3d34ca5)) * Generate `postgresql` as default destination in `gen` command ([#1863](#1863)) ([aad6218](aad6218)) * Generate auto-filled config ([#1764](#1764)) ([2255404](2255404)) * Move to standalone postgresql plugin ([#2074](#2074)) ([a0de6d3](a0de6d3)) * **sync:** Default input directory to '.' ([#1869](#1869)) ([005c915](005c915)) * Use jsonb for json columns ([#1870](#1870)) ([78e37fc](78e37fc)) * Use new tag format to download plugins ([#1985](#1985)) ([583f54e](583f54e)) * Use spinner instead of progress bar ([#1829](#1829)) ([af9129e](af9129e)) ### Bug Fixes * Can't gen with specific version ([#1915](#1915)) ([b7ae169](b7ae169)) * Checksum validation ([#1637](#1637)) ([a899cce](a899cce)) * CLI dev version ([#1864](#1864)) ([9c18606](9c18606)) * **cli:** Fix cli version checking to work with monorepo ([#1510](#1510)) ([e0ddfcf](e0ddfcf)) * **cli:** Remove debug output printed to stdout ([#1929](#1929)) ([eec9627](eec9627)) * **deps:** Update github.com/hairyhenderson/go-fsimpl digest to dc4ac0a ([#1650](#1650)) ([9222b5a](9222b5a)) * **deps:** Update github.com/ProtonMail/go-crypto digest to 4b6e5c5 ([#1649](#1649)) ([c71d859](c71d859)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.1.2 ([#1750](#1750)) ([fbe1b78](fbe1b78)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.4 ([#1761](#1761)) ([7a83a65](7a83a65)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.5 ([#1769](#1769)) ([c9c8c05](c9c8c05)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.6 ([#1770](#1770)) ([5bc205e](5bc205e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.7 ([#1783](#1783)) ([c291499](c291499)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.8 ([#1784](#1784)) ([b64e2d1](b64e2d1)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.9 ([#1785](#1785)) ([c6e8cb0](c6e8cb0)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.4.0 ([#1786](#1786)) ([cba274b](cba274b)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.4.1 ([#1787](#1787)) ([bad385c](bad385c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.4.2 ([#1789](#1789)) ([79a46a2](79a46a2)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.5.0 ([#1792](#1792)) ([0b4834e](0b4834e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.5.2 ([#1793](#1793)) ([36fd6a1](36fd6a1)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.0 ([#1817](#1817)) ([bd68a9c](bd68a9c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.1 ([#1820](#1820)) ([2613e23](2613e23)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.2 ([#1838](#1838)) ([5b16c59](5b16c59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.1 ([#1865](#1865)) ([474bb70](474bb70)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.12 ([#1916](#1916)) ([27d8153](27d8153)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9 ([#1891](#1891)) ([3469f20](3469f20)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.0 ([#1997](#1997)) ([4fa40da](4fa40da)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.1 ([#2024](#2024)) ([8f88de4](8f88de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.2 ([#2044](#2044)) ([9b69b46](9b69b46)) * **deps:** Update module github.com/hashicorp/go-plugin to v1.4.5 ([#1665](#1665)) ([6107aef](6107aef)) * **deps:** Update module github.com/mattn/go-isatty to v0.0.16 ([#1666](#1666)) ([44f0998](44f0998)) * Don't print skip download message to console ([#2008](#2008)) ([a947d44](a947d44)) * **pg:** Fix PKs recreation when nothing changed ([#1938](#1938)) ([5db7baa](5db7baa)) * Quote kind string in generated yml files ([#1824](#1824)) ([6c184ce](6c184ce)) * **release:** Embed correct modules version ([#1849](#1849)) ([2095a3b](2095a3b)) * Remove deprecated firebase ([#1568](#1568)) ([a879709](a879709)) * Resolve plugin version from GitHub registry instead of gRPC call ([#1856](#1856)) ([14d2ca6](14d2ca6)) * Use correct binary path on Windows ([#1894](#1894)) ([1ee41e7](1ee41e7)) * Use postgres defaults in destination config ([#1846](#1846)) ([24bbbc1](24bbbc1)) * Use uppercase downloading during progress ([#2006](#2006)) ([e6a7a44](e6a7a44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Very subjective, but at least for GitHub registry I think the log message is enough, otherwise you'd get:
This message takes 20% from the stuff we print to console
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)