fix: Catch any unparseable strings#19284
Merged
kodiakhq[bot] merged 1 commit intomainfrom Oct 2, 2024
Merged
Conversation
Contributor
|
🚀 PostgreSQL Cloud UI deployed to Vercel: |
erezrokah
approved these changes
Oct 2, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
🤖 I have created a release *beep* *boop* --- ## [8.6.2](plugins-destination-postgresql-v8.6.1...plugins-destination-postgresql-v8.6.2) (2024-10-08) ### Bug Fixes * Catch any unparseable strings ([#19284](#19284)) ([24536fb](24536fb)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.64.0 ([#19287](#19287)) ([49941ee](49941ee)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.65.0 ([#19322](#19322)) ([87a68ea](87a68ea)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.66.0 ([#19332](#19332)) ([137a232](137a232)) * Update the helper text ([#19282](#19282)) ([2044260](2044260)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch any strings that can't be parsed - preventing the UI from hanging.
With this approach, the test connection will ultimately report the error state.