feat: Add Indexes to remove need for full index scan on deletion #18741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
reviewed
Jul 30, 2024
1 task
Member
Do we want to add one? We could add an additional field here https://github.com/cloudquery/plugin-sdk/blob/a0c96a69b4a87e8d5c018876130d92f9111c4040/schema/column.go#L45 |
Collaborator
Author
|
We could add it, but it wouldn't be simple because we have to retain the order of columns in the index. Maybe we can wait and see if another plugin needs this functionality and add it to the SDK in that case? |
Member
OK, then I would put this behind a spec option, not enabled by default. |
blesniewski
approved these changes
Aug 1, 2024
erezrokah
approved these changes
Aug 1, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [8.4.0](plugins-destination-postgresql-v8.3.1...plugins-destination-postgresql-v8.4.0) (2024-08-06) ### Features * Add Indexes to remove need for full index scan on deletion ([#18741](#18741)) ([cacad92](cacad92)) * Convert PostgreSQL connection string to secret ([#18859](#18859)) ([9a86eb2](9a86eb2)) ### Bug Fixes * **deps:** Update dependency @cloudquery/cloud-ui to v0.1.12 ([#18836](#18836)) ([b24afab](b24afab)) * **deps:** Update dependency @cloudquery/plugin-config-ui-connector to v0.2.10 ([#18850](#18850)) ([ec926b5](ec926b5)) * **deps:** Update dependency @cloudquery/plugin-config-ui-connector to v0.2.11 ([#18860](#18860)) ([f7287b9](f7287b9)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.41 ([#18824](#18824)) ([d0d10ac](d0d10ac)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.42 ([#18834](#18834)) ([827d13b](827d13b)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.44 ([#18838](#18838)) ([745aeca](745aeca)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.45 ([#18841](#18841)) ([4476f38](4476f38)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.46 ([#18844](#18844)) ([60f5924](60f5924)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.47 ([#18849](#18849)) ([029638e](029638e)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.50 ([#18861](#18861)) ([79b4291](79b4291)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.52 ([#18862](#18862)) ([c275aed](c275aed)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.53 ([#18863](#18863)) ([c64d143](c64d143)) * **deps:** Update material-ui monorepo ([#18803](#18803)) ([c62a0e1](c62a0e1)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.57.0 ([#18810](#18810)) ([42cc5de](42cc5de)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.57.1 ([#18830](#18830)) ([605c202](605c202)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.0 ([#18839](#18839)) ([6b57bca](6b57bca)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.1 ([#18852](#18852)) ([4320340](4320340)) * PostgreSQL improvements ([#18843](#18843)) ([99b428b](99b428b)) * PostgreSQL logo and helper texts ([#18848](#18848)) ([8b7f173](8b7f173)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can't add this as part of the table definition because we don't have a field that can contain data about arbitrary indexes, so we just always ensure the index is present.
I am not opposed to putting this behind a flag if we decide that it should not be rolled out to everyone