fix: Allow plugin install command to be run with a single-plugin spec
#18571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianogappa
approved these changes
Jul 15, 2024
Contributor
marianogappa
left a comment
There was a problem hiding this comment.
I think this change means that if they do run plugin install with 2 plugins we wouldn't do this check:
// here we check if source with different versions use the same destination and error out if yes
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
🤖 I have created a release *beep* *boop* --- ## [5.25.1](cli-v5.25.0...cli-v5.25.1) (2024-07-15) ### Bug Fixes * Allow `plugin install` command to be run with a single-plugin spec ([#18571](#18571)) ([4c15f86](4c15f86)) * Allow `tables` command to be run with a single-plugin spec ([#18542](#18542)) ([0ed62e5](0ed62e5)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.2 ([#18504](#18504)) ([2d80936](2d80936)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.3 ([#18513](#18513)) ([d12da90](d12da90)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #18542, so you can install a single plugin without linking it to a destination/source