Skip to content

feat: Add ElasticSearch destination connection test #18560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 3 commits into from
Jul 15, 2024
Merged

feat: Add ElasticSearch destination connection test #18560

kodiakhq merged 3 commits into from
Jul 15, 2024

Conversation

@blesniewski
Copy link
Contributor

@blesniewski blesniewski commented Jul 12, 2024

Summary

Adds connection test to ElasticSearch destination plugin
Also contains a small fix (which thankfully didn't cover any issues) to MongoDB destination connection test

@blesniewski blesniewski requested review from a team and savme and removed request for a team July 12, 2024 13:59
@blesniewski
Copy link
Contributor Author

blesniewski commented Jul 12, 2024 •
edited
Loading 

❯ cloudquery test-connection pg-elastic
Loading spec(s) from pg-elastic
Test Connection Results
source       postgresql (cloudquery/postgresql@v6.2.3)  Success
destination  elasticsearch (grpc@127.0.0.1:7777)        Failure: UNAUTHORIZED    unauthorized
status code is 401
Error: at least one test connection failed
❯ cloudquery test-connection pg-elastic
Loading spec(s) from pg-elastic
Test Connection Results
source       postgresql (cloudquery/postgresql@v6.2.3)  Success
destination  elasticsearch (grpc@127.0.0.1:7777)        Failure: UNREACHABLE     unreachable
an error happened during the Info query execution: dial tcp [::1]:9200: connect: connection refused
Error: at least one test connection failed
❯ cloudquery test-connection pg-elastic
Loading spec(s) from pg-elastic
Test Connection Results
source       postgresql (cloudquery/postgresql@v6.2.3)  Success
destination  elasticsearch (grpc@127.0.0.1:7777)        Failure: INVALID_SPEC    invalid spec
json: cannot unmarshal number into Go struct field Spec.addresses of type string
Error: at least one test connection failed
❯ cloudquery test-connection pg-elastic
Loading spec(s) from pg-elastic
Test Connection Results
source       postgresql (cloudquery/postgresql@v6.2.3)  Success
destination  elasticsearch (grpc@127.0.0.1:7777)        Success

savme
savme reviewed Jul 12, 2024
View reviewed changes
@blesniewski blesniewski requested a review from savme July 12, 2024 15:26
@blesniewski blesniewski added the automerge Automatically merge once required checks pass label Jul 15, 2024
@kodiakhq kodiakhq bot merged commit 95e656e into main Jul 15, 2024
@kodiakhq kodiakhq bot deleted the feat/elasticsearch-destination-connection-test branch July 15, 2024 11:55
This was referenced Jul 15, 2024
Merged
Merged
kodiakhq bot pushed a commit that referenced this pull request Jul 16, 2024
@cq-bot
chore(main): Release plugins-destination-elasticsearch v3.4.0 (#18517)
3f08d24 
🤖 I have created a release *beep* *boop*
---


## [3.4.0](plugins-destination-elasticsearch-v3.3.4...plugins-destination-elasticsearch-v3.4.0) (2024-07-16)


### Features

* Add ElasticSearch destination connection test ([#18560](#18560)) ([95e656e](95e656e))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.3 ([#18513](#18513)) ([d12da90](d12da90))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit that referenced this pull request Jul 16, 2024
@cq-bot
chore(main): Release plugins-destination-mongodb v2.5.0 (#18524)
ecc33ce 
🤖 I have created a release *beep* *boop*
---


## [2.5.0](plugins-destination-mongodb-v2.4.4...plugins-destination-mongodb-v2.5.0) (2024-07-16)


### Features

* Add ElasticSearch destination connection test ([#18560](#18560)) ([95e656e](95e656e))
* Add MongoDB destination connection test ([#18554](#18554)) ([a21a4b7](a21a4b7))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.3 ([#18513](#18513)) ([d12da90](d12da90))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murarustefaan murarustefaan Awaiting requested review from murarustefaan

1 more reviewer

@savme savme savme approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/plugin/destination/elasticsearch area/plugin/destination/mongodb automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blesniewski @savme @cq-bot