feat: Pass invocation ID to scheduler #18510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3145dd1 to
70049b1
Compare
blesniewski
approved these changes
Jul 10, 2024
| } | ||
| c.syncClient = syncClient.(*client.Client) | ||
| c.scheduler = scheduler.NewScheduler(scheduler.WithLogger(logger), scheduler.WithConcurrency(s.Concurrency)) | ||
| c.scheduler = scheduler.NewScheduler(scheduler.WithLogger(logger), scheduler.WithConcurrency(s.Concurrency), scheduler.WithInvocationID(options.InvocationID)) |
Contributor
There was a problem hiding this comment.
Suggested change
| c.scheduler = scheduler.NewScheduler(scheduler.WithLogger(logger), scheduler.WithConcurrency(s.Concurrency), scheduler.WithInvocationID(options.InvocationID)) | |
| c.scheduler = scheduler.NewScheduler( | |
| scheduler.WithLogger(logger), | |
| scheduler.WithConcurrency(s.Concurrency), | |
| scheduler.WithInvocationID(options.InvocationID), | |
| ) |
This was referenced Jul 9, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
#### Summary Follow up to #18510 (comment)
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [6.2.0](plugins-source-k8s-v6.1.4...plugins-source-k8s-v6.2.0) (2024-07-16) ### Features * Pass invocation ID to scheduler ([#18510](#18510)) ([2fd34f8](2fd34f8)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.3 ([#18513](#18513)) ([d12da90](d12da90)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-source-xkcd-v1.0.6...plugins-source-xkcd-v1.1.0) (2024-07-16) ### Features * Pass invocation ID to scheduler ([#18510](#18510)) ([2fd34f8](2fd34f8)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.3 ([#18513](#18513)) ([d12da90](d12da90)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [4.3.0](plugins-source-test-v4.2.17...plugins-source-test-v4.3.0) (2024-07-16) ### Features * Pass invocation ID to scheduler ([#18510](#18510)) ([2fd34f8](2fd34f8)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.3 ([#18513](#18513)) ([d12da90](d12da90)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [3.3.0](plugins-source-hackernews-v3.2.4...plugins-source-hackernews-v3.3.0) (2024-07-16) ### Features * Pass invocation ID to scheduler ([#18510](#18510)) ([2fd34f8](2fd34f8)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.3 ([#18513](#18513)) ([d12da90](d12da90)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/cloudquery/cloudquery-issues/issues/1995 (internal issue).
This is needed so invocation ID is properly added to traces here https://github.com/cloudquery/plugin-sdk/blob/8bd1301a028820a7689836b61a6e9e7fec4269bb/scheduler/scheduler.go#L183