feat: Add per table sync metrics file flag #18397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Jun 25, 2024
erezrokah
commented
Jun 25, 2024
a0411a7 to
9abf09e
Compare
marianogappa
approved these changes
Jun 27, 2024
Contributor
marianogappa
left a comment
There was a problem hiding this comment.
I added a few comments. It's not a bulletproof review because I'm a little unfamiliar with Go's otel (I've used it in Python). I assume you've tested this code and it largely works.
Member
Author
|
This works only with plugins released with cloudquery/plugin-sdk#1751 so I'll wait before merging this |
Member
Author
OK so I'll actually mark this as a hidden flag so I can release the CLI, then unhide it once all plugins are updated |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
🤖 I have created a release *beep* *boop* --- ## [5.24.0](cli-v5.23.4...cli-v5.24.0) (2024-06-27) ### Features * Add per table sync metrics file flag ([#18397](#18397)) ([4fd9c94](4fd9c94)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.0 ([#18415](#18415)) ([3f4ef53](3f4ef53)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Goes with cloudquery/plugin-sdk#1751
Opening for reference