fix: Fix hardcoded status property on sync_run_completed. #18372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Jun 25, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
🤖 I have created a release *beep* *boop* --- ## [5.23.1](cli-v5.23.0...cli-v5.23.1) (2024-06-25) ### Bug Fixes * **deps:** Update module github.com/hashicorp/go-retryablehttp to v0.7.7 [SECURITY] ([#18369](#18369)) ([1e223bf](1e223bf)) * Fix hardcoded status property on sync_run_completed. ([#18372](#18372)) ([024a7ae](024a7ae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug discovered in this Slack thread: https://cloudqueryio.slack.com/archives/C0774DTKDJT/p1719328163706899
Which discusses this issue:
https://github.com/cloudquery/cloudquery-issues/issues/1911
Which says: