Skip to content

fix: Use plain email string for user email #18208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Jun 11, 2024
Merged

fix: Use plain email string for user email #18208

kodiakhq merged 2 commits into from
Jun 11, 2024

Conversation

@hermanschaaf
Copy link
Member

@hermanschaaf hermanschaaf commented Jun 11, 2024

Otherwise MarshalJSON gets called on it, which leads to an error for an empty email address:

2024/06/11 14:42:52 ERROR: json: error calling MarshalJSON for type types.Email: email: failed to pass regex validation - {track 441f7b51-559a-4f0f-86c9-249528aa85c8 7c7b9a79-2e47-48a1-963d-9be3fd79a5f1 00000000-0000-0000-0000-000000000000 sync_run_started 2024-06-11 14:42:52.280882 +0300 EEST m=+4.534407834 2024-06-11 14:42:52.280882 +0300 EEST m=+4.534407834 0x140008dadc0 map[destination_paths:[cloudquery/postgresql] environment:cli invocation_uuid:58de237a-ceb0-472b-821e-288ea6555062 source_path:cloudquery/aws sync_name:aws sync_run_id:58de237a-ceb0-472b-821e-288ea6555062 team:cloudquery user_email: user_id:00000000-0000-0000-0000-000000000000] map[] server}

@hermanschaaf hermanschaaf requested review from a team, erezrokah and marianogappa and removed request for a team and marianogappa June 11, 2024 12:08
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Jun 11, 2024
@kodiakhq kodiakhq bot merged commit 6c396a2 into main Jun 11, 2024
@kodiakhq kodiakhq bot deleted the rudderstack-fix branch June 11, 2024 12:54
@cq-bot cq-bot mentioned this pull request Jun 11, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 11, 2024
@cq-bot
chore(main): Release cli v5.21.1 (#18212)
524b813 
🤖 I have created a release *beep* *boop*
---


## [5.21.1](cli-v5.21.0...cli-v5.21.1) (2024-06-11)


### Bug Fixes

* Use plain email string for user email ([#18208](#18208)) ([6c396a2](6c396a2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@erezrokah erezrokah mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marianogappa marianogappa marianogappa approved these changes

@erezrokah erezrokah Awaiting requested review from erezrokah

Assignees

No one assigned

Labels

area/cli automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hermanschaaf @marianogappa @erezrokah @cq-bot