fix: Remove outdated login hint message#18044
Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom May 24, 2024
Merged
Conversation
candiduslynx
approved these changes
May 24, 2024
Member
Author
|
OK had to do another commit to only remove the warning. The initial PR changed so we return an error instead of The issue is that we can't really check if a token is needed just by looking at the spec, we need to see if the plugins are also pre-downloaded which would require a bit of work |
kodiakhq bot
pushed a commit
that referenced
this pull request
May 24, 2024
🤖 I have created a release *beep* *boop* --- ## [5.20.2](cli-v5.20.1...cli-v5.20.2) (2024-05-24) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.16 ([#18041](#18041)) ([9d62b39](9d62b39)) * Remove outdated login hint message ([#18044](#18044)) ([6b5a9a5](6b5a9a5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This message is outdated and doesn't work well when someone has the plugins pre-downloaded already (e.g. using an offline license).