Skip to content

feat: Sync Metadata table #17842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 35 commits into from
May 14, 2024
Merged

feat: Sync Metadata table #17842

kodiakhq merged 35 commits into from
May 14, 2024

Conversation

@bbernays
Copy link
Collaborator

@bbernays bbernays commented May 1, 2024 •
edited by hermanschaaf
Loading

No description provided.

@cq-bot cq-bot added the area/cli label May 1, 2024
@bbernays bbernays requested a review from hermanschaaf May 1, 2024 18:33
hermanschaaf
hermanschaaf reviewed May 2, 2024
View reviewed changes
hermanschaaf
hermanschaaf reviewed May 2, 2024
View reviewed changes
@hermanschaaf
Copy link
Member

hermanschaaf commented May 2, 2024

I tried it out locally, but got an error:

{"level":"info","module":"cli","invocation-id":"a8834301-9983-43f4-94fc-e7898d17d5a1","address":"/var/folders/_c/hm9lkvfj7fz_rykn71rmr8gh0000gn/T/cq-gQebwPMMfbrFKgWU.sock","message":"Got stop signal. Plugin server shutting down","signal":"interrupt","time":"2024-05-02T11:03:45Z"}
Error: failed to sync v3 source k8s: failed to send write request (migrate sync summary table): rpc error: code = Internal desc = SendMsg called after CloseSend
{"level":"error","module":"cli","invocation-id":"a8834301-9983-43f4-94fc-e7898d17d5a1","error":"failed to sync v3 source k8s: failed to send write request (migrate sync summary table): rpc error: code = Internal desc = SendMsg called after CloseSend","time":"2024-05-02T11:03:45Z","message":"exiting with error"}

hermanschaaf
hermanschaaf reviewed May 2, 2024
View reviewed changes
hermanschaaf
hermanschaaf reviewed May 2, 2024
View reviewed changes
@hermanschaaf
Copy link
Member

hermanschaaf commented May 2, 2024

I tried it out locally, but got an error:

☝️ I pushed a fix for this

@bbernays bbernays marked this pull request as ready for review May 3, 2024 11:29
@bbernays bbernays requested review from a team and savme and removed request for a team May 3, 2024 11:29
@bbernays bbernays changed the title feat: Sync summary table feat: Sync Metadata table May 3, 2024
savme
savme approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@savme savme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🚀

erezrokah
erezrokah reviewed May 6, 2024
View reviewed changes
erezrokah
erezrokah reviewed May 6, 2024
View reviewed changes
erezrokah
erezrokah reviewed May 6, 2024
View reviewed changes
erezrokah
erezrokah reviewed May 10, 2024
View reviewed changes
erezrokah
erezrokah reviewed May 14, 2024
View reviewed changes
erezrokah
erezrokah reviewed May 14, 2024
View reviewed changes
@bbernays @erezrokah
Apply suggestions from code review
01a8626 
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
@bbernays bbernays added the automerge Automatically merge once required checks pass label May 14, 2024
@erezrokah erezrokah removed the automerge Automatically merge once required checks pass label May 14, 2024
@erezrokah
Copy link
Member

erezrokah commented May 14, 2024

@bbernays I removed automerge as we should add some docs for this

@bbernays bbernays added the automerge Automatically merge once required checks pass label May 14, 2024
@kodiakhq kodiakhq bot merged commit 377bde2 into main May 14, 2024
@kodiakhq kodiakhq bot deleted the sync-summary-table-2 branch May 14, 2024 20:44
@cq-bot cq-bot mentioned this pull request May 14, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request May 17, 2024
@cq-bot
chore(main): Release cli v5.19.0 (#17960)
9adeb45 
🤖 I have created a release *beep* *boop*
---


## [5.19.0](cli-v5.18.2...cli-v5.19.0) (2024-05-17)


### Features

* Sync Metadata table ([#17842](#17842)) ([377bde2](377bde2))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.42.1 ([#17965](#17965)) ([d652b81](d652b81))
* Remove JSON schema validation warnings ([#17994](#17994)) ([7a7ff25](7a7ff25))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermanschaaf hermanschaaf hermanschaaf left review comments

@erezrokah erezrokah erezrokah approved these changes

+1 more reviewer

@savme savme savme approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/cli area/website automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bbernays @hermanschaaf @erezrokah @savme @cq-bot