feat(resources): Add support for GCP organization and project tags#14638
Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom Oct 19, 2023
Merged
feat(resources): Add support for GCP organization and project tags#14638kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
Conversation
Contributor
This PR has the following changes to source plugin(s) tables:
|
erezrokah
reviewed
Oct 18, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Nice work @DougEverly, added a few comments regarding conventions we have.
Also do you mind add mock tests? See example in https://github.com/cloudquery/cloudquery/blob/e5a367e54fe67fc1fca0448a8d4cd9fac670c95a/plugins/source/gcp/resources/services/resourcemanager/projects_mock_test.go
plugins/source/gcp/resources/services/resourcemanager/organization_tag_values.go
Outdated
Show resolved
Hide resolved
plugins/source/gcp/resources/services/resourcemanager/tag_keys.go
Outdated
Show resolved
Hide resolved
plugins/source/gcp/resources/services/resourcemanager/tag_values.go
Outdated
Show resolved
Hide resolved
* Use gcp_resourcemanager_organization_ and gcp_resourcemanager_project_ prefixes for consistency. * Added mock tests. * Consolidated table, fetch, and mock code.
erezrokah
approved these changes
Oct 19, 2023
Member
There was a problem hiding this comment.
Looks great @DougEverly, thanks for adding the tests and following up on my comments. I pushed a small commit to remove a Printf and fix a typo
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
🤖 I have created a release *beep* *boop* --- ## [9.8.0](plugins-source-gcp-v9.7.0...plugins-source-gcp-v9.8.0) (2023-10-19) ### This Release has the Following Changes to Tables - Table `gcp_resourcemanager_organization_tag_keys` was added - Table `gcp_resourcemanager_organization_tag_values` was added - Table `gcp_resourcemanager_project_tag_bindings` was added - Table `gcp_resourcemanager_project_tag_keys` was added - Table `gcp_resourcemanager_project_tag_values` was added ### Features * Move gcp to dbt (only 1 section) ([#14458](#14458)) ([46c28e7](46c28e7)) * **resources:** Add support for GCP organization and project tags ([#14638](#14638)) ([8fa403f](8fa403f)) ### Bug Fixes * Add descriptions to spec JSON schema ([#14671](#14671)) ([30090e8](30090e8)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to d401686 ([#14459](#14459)) ([7ce40f8](7ce40f8)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to dbcb149 ([#14537](#14537)) ([68686f4](68686f4)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.6 ([#14475](#14475)) ([83fe7ca](83fe7ca)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.8 ([#14503](#14503)) ([4056593](4056593)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.9 ([#14627](#14627)) ([c1d244c](c1d244c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.3.0 ([#14635](#14635)) ([00b380c](00b380c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.4.0 ([#14639](#14639)) ([f139c0e](f139c0e)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.6 ([#14466](#14466)) ([32b5a90](32b5a90)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.8 ([#14532](#14532)) ([1ecef25](1ecef25)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.9 ([#14660](#14660)) ([68ab0bb](68ab0bb)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([#14378](#14378)) ([a2e0c46](a2e0c46)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.3 ([#14436](#14436)) ([d529e2d](d529e2d)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.4 ([#14489](#14489)) ([9bb45dc](9bb45dc)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.5 ([#14516](#14516)) ([2d905bf](2d905bf)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.14.0 ([#14577](#14577)) ([223c4c1](223c4c1)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.15.0 ([#14622](#14622)) ([b497a6b](b497a6b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.15.2 ([#14662](#14662)) ([e274fe4](e274fe4)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.15.3 ([#14679](#14679)) ([0513c19](0513c19)) * **deps:** Update module golang.org/x/net to v0.17.0 [SECURITY] ([#14500](#14500)) ([9e603d5](9e603d5)) * Proper validation for `project_filter` mutually exclusive with `folder_ids` ([#14448](#14448)) ([4cb898e](4cb898e)) * Set plugin metadata ([#14715](#14715)) ([39935e2](39935e2)) * Update plugin-SDK to v4.16.0 ([#14702](#14702)) ([0dcb545](0dcb545)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
…loudquery#14638) #### Sync GCP Organization and Project Tags * Sync tagKeys and tagValues for organizations * Sync tagKeys, tagValues, and tagBindings for projects. <!--
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
🤖 I have created a release *beep* *boop* --- ## [9.8.0](cloudquery/cloudquery@plugins-source-gcp-v9.7.0...plugins-source-gcp-v9.8.0) (2023-10-19) ### This Release has the Following Changes to Tables - Table `gcp_resourcemanager_organization_tag_keys` was added - Table `gcp_resourcemanager_organization_tag_values` was added - Table `gcp_resourcemanager_project_tag_bindings` was added - Table `gcp_resourcemanager_project_tag_keys` was added - Table `gcp_resourcemanager_project_tag_values` was added ### Features * Move gcp to dbt (only 1 section) ([cloudquery#14458](cloudquery#14458)) ([46c28e7](cloudquery@46c28e7)) * **resources:** Add support for GCP organization and project tags ([cloudquery#14638](cloudquery#14638)) ([8fa403f](cloudquery@8fa403f)) ### Bug Fixes * Add descriptions to spec JSON schema ([cloudquery#14671](cloudquery#14671)) ([30090e8](cloudquery@30090e8)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to d401686 ([cloudquery#14459](cloudquery#14459)) ([7ce40f8](cloudquery@7ce40f8)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to dbcb149 ([cloudquery#14537](cloudquery#14537)) ([68686f4](cloudquery@68686f4)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.6 ([cloudquery#14475](cloudquery#14475)) ([83fe7ca](cloudquery@83fe7ca)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.8 ([cloudquery#14503](cloudquery#14503)) ([4056593](cloudquery@4056593)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.9 ([cloudquery#14627](cloudquery#14627)) ([c1d244c](cloudquery@c1d244c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.3.0 ([cloudquery#14635](cloudquery#14635)) ([00b380c](cloudquery@00b380c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.4.0 ([cloudquery#14639](cloudquery#14639)) ([f139c0e](cloudquery@f139c0e)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.6 ([cloudquery#14466](cloudquery#14466)) ([32b5a90](cloudquery@32b5a90)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.8 ([cloudquery#14532](cloudquery#14532)) ([1ecef25](cloudquery@1ecef25)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.9 ([cloudquery#14660](cloudquery#14660)) ([68ab0bb](cloudquery@68ab0bb)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([cloudquery#14378](cloudquery#14378)) ([a2e0c46](cloudquery@a2e0c46)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.3 ([cloudquery#14436](cloudquery#14436)) ([d529e2d](cloudquery@d529e2d)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.4 ([cloudquery#14489](cloudquery#14489)) ([9bb45dc](cloudquery@9bb45dc)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.5 ([cloudquery#14516](cloudquery#14516)) ([2d905bf](cloudquery@2d905bf)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.14.0 ([cloudquery#14577](cloudquery#14577)) ([223c4c1](cloudquery@223c4c1)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.15.0 ([cloudquery#14622](cloudquery#14622)) ([b497a6b](cloudquery@b497a6b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.15.2 ([cloudquery#14662](cloudquery#14662)) ([e274fe4](cloudquery@e274fe4)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.15.3 ([cloudquery#14679](cloudquery#14679)) ([0513c19](cloudquery@0513c19)) * **deps:** Update module golang.org/x/net to v0.17.0 [SECURITY] ([cloudquery#14500](cloudquery#14500)) ([9e603d5](cloudquery@9e603d5)) * Proper validation for `project_filter` mutually exclusive with `folder_ids` ([cloudquery#14448](cloudquery#14448)) ([4cb898e](cloudquery@4cb898e)) * Set plugin metadata ([cloudquery#14715](cloudquery#14715)) ([39935e2](cloudquery@39935e2)) * Update plugin-SDK to v4.16.0 ([cloudquery#14702](cloudquery#14702)) ([0dcb545](cloudquery@0dcb545)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync GCP Organization and Project Tags