fix: Late setup for format and stage#14528
Merged
kodiakhq[bot] merged 1 commit intomainfrom Oct 13, 2023
Merged
Conversation
erezrokah
reviewed
Oct 13, 2023
| spec Spec | ||
| writer *batchwriter.BatchWriter | ||
|
|
||
| setupWriteOnce *sync.Once |
Member
There was a problem hiding this comment.
We could use the fancy new https://pkg.go.dev/sync#OnceValue now that we're on Go 1.21
Member
Author
There was a problem hiding this comment.
We could, but init wasn't a good place for write-related code anyway. Plus if we did that we'd need to use the ctx from New and not Write?
Member
There was a problem hiding this comment.
Yeah, non blocking comment this is good to go
erezrokah
approved these changes
Oct 13, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
Fix for #14528 Previously PR was essentially a no-op since a migrate message is also passed from client.Write. ~Still needs testing.~
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
🤖 I have created a release *beep* *boop* --- ## [3.2.7](plugins-destination-snowflake-v3.2.6...plugins-destination-snowflake-v3.2.7) (2023-10-16) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to d401686 ([#14459](#14459)) ([7ce40f8](7ce40f8)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to dbcb149 ([#14537](#14537)) ([68686f4](68686f4)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.6 ([#14475](#14475)) ([83fe7ca](83fe7ca)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.8 ([#14503](#14503)) ([4056593](4056593)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([#14378](#14378)) ([a2e0c46](a2e0c46)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.3 ([#14436](#14436)) ([d529e2d](d529e2d)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.4 ([#14489](#14489)) ([9bb45dc](9bb45dc)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.5 ([#14516](#14516)) ([2d905bf](2d905bf)) * **deps:** Update module golang.org/x/net to v0.17.0 [SECURITY] ([#14500](#14500)) ([9e603d5](9e603d5)) * Late setup for format and stage ([#14528](#14528)) ([dcf1a36](dcf1a36)) * Setup write before WriteMessage processing ([#14530](#14530)) ([07357bb](07357bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Shouldn't attempt to `CREATE STAGE` and `CREATE FORMAT` before migrate starts so we can have `cloudquery migrate` with fewer permissions required.
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Fix for cloudquery#14528 Previously PR was essentially a no-op since a migrate message is also passed from client.Write. ~Still needs testing.~
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
…#14398) 🤖 I have created a release *beep* *boop* --- ## [3.2.7](cloudquery/cloudquery@plugins-destination-snowflake-v3.2.6...plugins-destination-snowflake-v3.2.7) (2023-10-16) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to d401686 ([cloudquery#14459](cloudquery#14459)) ([7ce40f8](cloudquery@7ce40f8)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to dbcb149 ([cloudquery#14537](cloudquery#14537)) ([68686f4](cloudquery@68686f4)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.6 ([cloudquery#14475](cloudquery#14475)) ([83fe7ca](cloudquery@83fe7ca)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.8 ([cloudquery#14503](cloudquery#14503)) ([4056593](cloudquery@4056593)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([cloudquery#14378](cloudquery#14378)) ([a2e0c46](cloudquery@a2e0c46)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.3 ([cloudquery#14436](cloudquery#14436)) ([d529e2d](cloudquery@d529e2d)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.4 ([cloudquery#14489](cloudquery#14489)) ([9bb45dc](cloudquery@9bb45dc)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.5 ([cloudquery#14516](cloudquery#14516)) ([2d905bf](cloudquery@2d905bf)) * **deps:** Update module golang.org/x/net to v0.17.0 [SECURITY] ([cloudquery#14500](cloudquery#14500)) ([9e603d5](cloudquery@9e603d5)) * Late setup for format and stage ([cloudquery#14528](cloudquery#14528)) ([dcf1a36](cloudquery@dcf1a36)) * Setup write before WriteMessage processing ([cloudquery#14530](cloudquery#14530)) ([07357bb](cloudquery@07357bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shouldn't attempt to
CREATE STAGEandCREATE FORMATbefore migrate starts so we can havecloudquery migratewith fewer permissions required.