fix: Publish columns with tables#14373
Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom Oct 5, 2023
Merged
Conversation
disq
approved these changes
Oct 5, 2023
erezrokah
pushed a commit
that referenced
this pull request
Oct 6, 2023
🤖 I have created a release *beep* *boop* --- ## [3.21.2](cli-v3.21.1...cli-v3.21.2) (2023-10-06) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.3 ([#14337](#14337)) ([37b8097](37b8097)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.12.0 ([#14370](#14370)) ([43eb632](43eb632)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.12.1 ([#14377](#14377)) ([c696bec](c696bec)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([#14378](#14378)) ([a2e0c46](a2e0c46)) * Publish columns with tables ([#14373](#14373)) ([4e15e2a](4e15e2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
#### Summary Along with cloudquery/plugin-sdk#1270 this fixes the missing columns for tables during publish (we only need to update the Go client to get the new model we unmarshal, see https://github.com/cloudquery/cloudquery-api-go/pull/25/files#diff-1edd75be97030ae0efe21c3bbaa6f62a7b4cf00cb0df07bb060e669fd3124698R373 https://github.com/cloudquery/cloudquery/blob/285d10d01b75e49e0a7cf9e83b24ee4a3e341553/cli/cmd/publish.go#L218 <!--
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
🤖 I have created a release *beep* *boop* --- ## [3.21.2](cloudquery/cloudquery@cli-v3.21.1...cli-v3.21.2) (2023-10-06) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.3 ([cloudquery#14337](cloudquery#14337)) ([37b8097](cloudquery@37b8097)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.12.0 ([cloudquery#14370](cloudquery#14370)) ([43eb632](cloudquery@43eb632)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.12.1 ([cloudquery#14377](cloudquery#14377)) ([c696bec](cloudquery@c696bec)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([cloudquery#14378](cloudquery#14378)) ([a2e0c46](cloudquery@a2e0c46)) * Publish columns with tables ([cloudquery#14373](cloudquery#14373)) ([4e15e2a](cloudquery@4e15e2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Along with cloudquery/plugin-sdk#1270 this fixes the missing columns for tables during publish (we only need to update the Go client to get the new model we unmarshal, see
https://github.com/cloudquery/cloudquery-api-go/pull/25/files#diff-1edd75be97030ae0efe21c3bbaa6f62a7b4cf00cb0df07bb060e669fd3124698R373
cloudquery/cli/cmd/publish.go
Line 218 in 285d10d