Skip to content

fix: K8s Mock Testing#1434

Merged
erezrokah merged 3 commits intocloudquery:mainfrom
bbernays:fix-k8s
Aug 17, 2022
Merged

fix: K8s Mock Testing#1434
erezrokah merged 3 commits intocloudquery:mainfrom
bbernays:fix-k8s

Conversation

@bbernays
Copy link
Copy Markdown
Collaborator

Summary

In my local IDE (vscode) gpls reports errors. This PR fixes it


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Test locally on your own infrastructure
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@bbernays bbernays added the k8s label Aug 16, 2022
@bbernays bbernays requested review from roneli and spangenberg August 16, 2022 20:01
@github-actions github-actions bot added the fix label Aug 16, 2022
@github-actions github-actions bot added fix and removed fix labels Aug 17, 2022
@github-actions github-actions bot added fix and removed fix labels Aug 17, 2022
@erezrokah
Copy link
Copy Markdown
Member

Thanks for the PR @bbernays, I added another commit in 8b26a6d so go test ./... will run the tests. As a result I had to fix a bunch of issues which are in that same commit.

@github-actions github-actions bot added fix and removed fix labels Aug 17, 2022
Copy link
Copy Markdown
Contributor

@spangenberg spangenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't love the import alias k8sTesting but still fine.
LGTM

@erezrokah erezrokah merged commit 3f4b37e into cloudquery:main Aug 17, 2022
kodiakhq bot pushed a commit that referenced this pull request Aug 18, 2022
🤖 I have created a release *beep* *boop*
---


## [0.6.4](plugins/source/k8s-v0.6.3...plugins/source/k8s/v0.6.4) (2022-08-18)


### Features

* Add website, docs and blog to our main repo ([#1159](#1159)) ([dd69948](dd69948))


### Bug Fixes

* Deprecate `cluster_name` field and enable mock tests ([#1434](#1434)) ([3f4b37e](3f4b37e))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
daniel-garcia pushed a commit to infobloxopen/ibcq-source-k8s that referenced this pull request Feb 24, 2026
🤖 I have created a release *beep* *boop*
---


## [0.6.4](cloudquery/cloudquery@plugins/source/k8s-v0.6.3...plugins/source/k8s/v0.6.4) (2022-08-18)


### Features

* Add website, docs and blog to our main repo ([#1159](cloudquery/cloudquery#1159)) ([1ba9fe0](cloudquery/cloudquery@1ba9fe0))


### Bug Fixes

* Deprecate `cluster_name` field and enable mock tests ([#1434](cloudquery/cloudquery#1434)) ([d357d14](cloudquery/cloudquery@d357d14))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants