Merged
Conversation
erezrokah
approved these changes
Oct 2, 2023
candiduslynx
reviewed
Oct 2, 2023
| return "" | ||
| } | ||
|
|
||
| func isErrH2GoAway(err error) bool { |
Contributor
There was a problem hiding this comment.
why not check for errors.Is(http2.GoAwayError)?
https://pkg.go.dev/golang.org/x/net/http2#GoAwayError
Member
Author
There was a problem hiding this comment.
@candiduslynx http2.GoAwayError is a type and not a variable, errors.Is won't catch it. dfe06d9 (#14273) uses errors.As now, but it isn't as pretty.
Contributor
There was a problem hiding this comment.
you need to match only the var he http2.GoAwayError as the receiver for Error() func is value, not pointer
bbernays
approved these changes
Oct 2, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
🤖 I have created a release *beep* *boop* --- ## [3.1.2](plugins-source-shopify-v3.1.1...plugins-source-shopify-v3.1.2) (2023-10-02) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v14 digest to 00efb06 ([#14202](#14202)) ([fc8cc62](fc8cc62)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 7ded38b ([#14246](#14246)) ([005891e](005891e)) * Retry on http2 GOAWAY error ([#14273](#14273)) ([5d5471c](5d5471c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
Based on your fix I restarted the sync on one of my smaller stores. I'll keep you posted on the progress. |
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
🤖 I have created a release *beep* *boop* --- ## [3.1.2](cloudquery/cloudquery@plugins-source-shopify-v3.1.1...plugins-source-shopify-v3.1.2) (2023-10-02) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v14 digest to 00efb06 ([cloudquery#14202](cloudquery#14202)) ([fc8cc62](cloudquery@fc8cc62)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 7ded38b ([cloudquery#14246](cloudquery#14246)) ([005891e](cloudquery@005891e)) * Retry on http2 GOAWAY error ([cloudquery#14273](cloudquery#14273)) ([5d5471c](cloudquery@5d5471c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13865