Merged
Conversation
erezrokah
reviewed
Oct 2, 2023
|
|
||
| Specify which accounts to sync data from. | ||
|
|
||
| - `site` (`string`, optional, default: "") |
Member
There was a problem hiding this comment.
Is setting an empty string (using the default) the same as setting it to datadoghq.com? Maybe we should clarify that if that's the case
Contributor
Author
There was a problem hiding this comment.
Yes, it falls back on this configuration if there is not a site override in the context.
erezrokah
approved these changes
Oct 2, 2023
Member
|
Looks good, one non blocking comment |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](plugins-source-datadog-v4.0.0...plugins-source-datadog-v4.1.0) (2023-10-02) ### Features * Add configurable site ([#14266](#14266)) ([2c80f91](2c80f91)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v14 digest to 00efb06 ([#14202](#14202)) ([fc8cc62](fc8cc62)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 7ded38b ([#14246](#14246)) ([005891e](005891e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Add configurable site to allow other DDog regional sites to be used, if no site is specified the existing behaviour is preserved. fixes: cloudquery#14265
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](cloudquery/cloudquery@plugins-source-datadog-v4.0.0...plugins-source-datadog-v4.1.0) (2023-10-02) ### Features * Add configurable site ([cloudquery#14266](cloudquery#14266)) ([2c80f91](cloudquery@2c80f91)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v14 digest to 00efb06 ([cloudquery#14202](cloudquery#14202)) ([fc8cc62](cloudquery@fc8cc62)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 7ded38b ([cloudquery#14246](cloudquery#14246)) ([005891e](cloudquery@005891e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable site to allow other DDog regional sites to be used, if no site is specified the existing behaviour is preserved.
fixes: #14265