Skip to content

fix: Issue #13433 - match on lowercase "redirect" in aws policy #13751

Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
obormot:fix-#13433
Sep 7, 2023
Merged

fix: Issue #13433 - match on lowercase "redirect" in aws policy #13751
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
obormot:fix-#13433

Conversation

@obormot
Copy link
Copy Markdown
Contributor

@obormot obormot commented Sep 7, 2023

Summary

Fix a bug in plugins/source/aws/policies/queries/elb/elbv2_redirect_http_to_https.sql that tries to match on uppercase "REDIRECT" while the data in aws_elbv2_listeners shows the lowercase "redirect" (see issue #13433 for detail). This bug causes false positive matches in the aws policy.

Fixes #13433

@cq-bot cq-bot added the aws label Sep 7, 2023
@obormot obormot changed the title fix: issue #13433 - match on lowercase "redirect" in aws policy fix: Issue #13433 - match on lowercase "redirect" in aws policy Sep 7, 2023
@erezrokah erezrokah requested a review from jsonpr September 7, 2023 05:09
Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Sep 7, 2023
@erezrokah erezrokah removed the request for review from jsonpr September 7, 2023 05:13
@erezrokah
Copy link
Copy Markdown
Member

/gen sha=4d0391d998b6e441ef773fdb28802cbd4d89fc84 plugin=aws

@cq-bot cq-bot added the website label Sep 7, 2023
@kodiakhq kodiakhq bot merged commit 539e029 into cloudquery:main Sep 7, 2023
kodiakhq bot pushed a commit that referenced this pull request Sep 7, 2023
🤖 I have created a release *beep* *boop*
---


## [22.10.0](plugins-source-aws-v22.9.0...plugins-source-aws-v22.10.0) (2023-09-07)


### Features

* Add scheduler option to AWS ([#13757](#13757)) ([521918f](521918f))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.7.1 ([#13713](#13713)) ([73004dc](73004dc))
* Issue [#13433](#13433) - match on lowercase "redirect" in aws policy  ([#13751](#13751)) ([539e029](539e029))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: aws policy elbv2_redirect_http_to_https.sql should match on lowercase "redirect"

3 participants