feat: Support reading private key from string#13556
Merged
kodiakhq[bot] merged 8 commits intocloudquery:mainfrom Sep 1, 2023
patriknordlen:github-app-credentials-from-env
Merged
feat: Support reading private key from string#13556kodiakhq[bot] merged 8 commits intocloudquery:mainfrom patriknordlen:github-app-credentials-from-env
kodiakhq[bot] merged 8 commits intocloudquery:mainfrom
patriknordlen:github-app-credentials-from-env
Conversation
erezrokah
reviewed
Aug 31, 2023
erezrokah
requested changes
Sep 1, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Thanks for following up @patriknordlen, added a couple of comments regarding the error messages
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Contributor
Author
Thanks for the suggestions, accepted and committed! |
erezrokah
approved these changes
Sep 1, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
🤖 I have created a release *beep* *boop* --- ## [7.3.0](plugins-source-github-v7.2.1...plugins-source-github-v7.3.0) (2023-09-01) ### Features * Support reading private key from string ([#13556](#13556)) ([9909e24](9909e24)) ### Bug Fixes * **deps:** Update github.com/99designs/go-keychain digest to 9cf53c8 ([#13561](#13561)) ([a170256](a170256)) * **deps:** Update github.com/beatlabs/github-auth digest to 39adf75 ([#13563](#13563)) ([ea5f471](ea5f471)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.6.0 ([#13492](#13492)) ([c305876](c305876)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #13555 by adding a
private_keyconfiguration key that can be used to read the private key from a string instead of a file.