Hi @joytandon17!

Shouldn't this already work with the current code given that the default creds will attempt to use OIDC based on the env variables set?
See https://learn.microsoft.com/en-us/azure/developer/go/azure-sdk-authentication?tabs=bash#-option-2-use-workload-identity

Hi @joytandon17!

Shouldn't this already work with the current code given that the default creds will attempt to use OIDC based on the env variables set? See https://learn.microsoft.com/en-us/azure/developer/go/azure-sdk-authentication?tabs=bash#-option-2-use-workload-identity

Hi @candiduslynx I think it only supports MSI(Managed Service Identity) Token which is from Azure itself, This PR would enable to use OIDC token(I think for which we need to use this function NewClientAssertionCredential) which is not generated from Azure but for example AWS Cognito, Please see this document
https://blog.identitydigest.com/azuread-federate-aws/

Hi @joytandon17 👋 Thanks for this PR! I think it makes sense from the perspective of supporting a new feature.

I'd like to request one or two changes if you don't mind:

• could you please remove the reliance on the OIDC_TOKEN environment variable and instead add an option to the spec (in client/spec.go) with the name oidc_token? The other environment variables like AZURE_TENANT_ID are special because they are recognized by the az CLI tool, but in general we prefer to add spec options rather than environment variables. This way users can use any environment variable name by using environment variable substitution in the config
• could you then also add some documentation for this new option to these two pages: https://github.com/cloudquery/cloudquery/blob/main/website/pages/docs/plugins/sources/azure/_configuration.mdx and https://github.com/cloudquery/cloudquery/blob/main/website/pages/docs/plugins/sources/azure/configuration.mdx. Just a short sentence or two would be fine.

Let me know if that makes sense and if we can help in any way!

Hi @joytandon17 👋 Thanks for this PR! I think it makes sense from the perspective of supporting a new feature.

I'd like to request one or two changes if you don't mind:

• could you please remove the reliance on the OIDC_TOKEN environment variable and instead add an option to the spec (in client/spec.go) with the name oidc_token? The other environment variables like AZURE_TENANT_ID are special because they are recognized by the az CLI tool, but in general we prefer to add spec options rather than environment variables. This way users can use any environment variable name by using environment variable substitution in the config
• could you then also add some documentation for this new option to these two pages: https://github.com/cloudquery/cloudquery/blob/main/website/pages/docs/plugins/sources/azure/_configuration.mdx and https://github.com/cloudquery/cloudquery/blob/main/website/pages/docs/plugins/sources/azure/configuration.mdx. Just a short sentence or two would be fine.

Let me know if that makes sense and if we can help in any way!

Hi @hermanschaaf, Thanks for the review, Will do the required changes.

@hermanschaaf can you please review the PR?
Also please ignore the tags added and removed by cqbot, I committed(by mistake) after merging main to my PR with some issues hence all the commits of main were showing here so I had to force push to previous commit to fix that.

Thanks for the contribution @joytandon17!