fix(cli): Send sync time to new sources#10796
Merged
kodiakhq[bot] merged 3 commits intomainfrom May 15, 2023
Merged
Conversation
Comment on lines
+111
to
113
| if !slices.Contains(versions, 1) { | ||
| return fmt.Errorf("destination %[1]s does not support CloudQuery SDK version 2. Please upgrade to newer version of %[1]s", destination.Spec.Name) | ||
| } |
Contributor
There was a problem hiding this comment.
Thinking about this now, should this rather be checking for versions greater or equal than 1?
Contributor
Author
There was a problem hiding this comment.
I think we don't yet. destination 2 might not work with source 2. all those issues will be solved when we will have one protocol where we will always know that a two plugins can only speak to each other if they have at least one common version
Member
There was a problem hiding this comment.
Maybe it's better to be explicit unless we know what the next version brings and if it's actually compatible and so on?
hermanschaaf
approved these changes
May 15, 2023
disq
approved these changes
May 15, 2023
candiduslynx
approved these changes
May 15, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 15, 2023
🤖 I have created a release *beep* *boop* --- ## [3.3.1](cli-v3.3.0...cli-v3.3.1) (2023-05-15) ### Bug Fixes * **cli:** Send sync time to new sources ([#10796](#10796)) ([8d9b5be](8d9b5be)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes version check in the new CLI and send sync time new sources.