fix(azure): Improve query of CIS v1.3.0 Section 4.2.1#10362
Merged
kodiakhq[bot] merged 8 commits intocloudquery:mainfrom May 11, 2023
Merged
fix(azure): Improve query of CIS v1.3.0 Section 4.2.1#10362kodiakhq[bot] merged 8 commits intocloudquery:mainfrom
kodiakhq[bot] merged 8 commits intocloudquery:mainfrom
Conversation
This PR has the following changes to source plugin(s) tables:
|
Contributor
Author
|
Hello, @yevgenypats -san, how is the status of reviewing this pull request? |
Contributor
|
/gen sha=d9fdc3ec190116f3f89423008e67b7cd5cba9f2b plugin=azure |
hermanschaaf
approved these changes
May 11, 2023
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Looks good to me, sorry for the delay in reviewing this @aruneko ! Thank you for the great contribution 👍
kodiakhq bot
pushed a commit
that referenced
this pull request
May 16, 2023
🤖 I have created a release *beep* *boop* --- ## [7.5.0](plugins-source-azure-v7.4.1...plugins-source-azure-v7.5.0) (2023-05-16) ### This Release has the Following Changes to Tables - Table `azure_sql_server_advanced_threat_protection_settings` was added ### Features * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) ### Bug Fixes * **azure:** Improve query of CIS v1.3.0 Section 4.2.1 ([#10362](#10362)) ([48138be](48138be)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that the current query of CIS v1.3.0 Section 4.2.1 checks the ATP (Advanced Threat Protection) status by SQL databases. But the original document says that the we have to check the status by SQL Servers.
In addition, even though I have enabled the ATP settings on my Azure SQL Server, current query always returns
fails, because the status is managed by not database level but server level.To solve the problem, I have added a new table
azure_sql_server_advanced_threat_protection_settingsto store the status, and use the table to check the policy.