fix(gcp-resources): Add project_id and id as PKs of gcp_bigquery_datasets (#6532)

erezrokah · web-flow · commit fd001337c2c8 · 2023-01-09T16:18:34.000Z
#### Summary

Add missing PK(s) for `gcp_bigquery_datasets`. Non breaking as the data should exist

&lt;!--
diff --git a/plugins/source/gcp/docs/tables/gcp_bigquery_datasets.md b/plugins/source/gcp/docs/tables/gcp_bigquery_datasets.md
@@ -2,7 +2,7 @@
 
 https://cloud.google.com/bigquery/docs/reference/rest/v2/datasets#Dataset
 
-The primary key for this table is **_cq_id**.
+The composite primary key for this table is (**project_id**, **id**).
 
 ## Relations
 
@@ -15,9 +15,10 @@ The following tables depend on gcp_bigquery_datasets:
 | ------------- | ------------- |
 |_cq_source_name|String|
 |_cq_sync_time|Timestamp|
-|_cq_id (PK)|UUID|
+|_cq_id|UUID|
 |_cq_parent_id|UUID|
-|project_id|String|
+|project_id (PK)|String|
+|id (PK)|String|
 |access|JSON|
 |creation_time|Int|
 |dataset_reference|JSON|
@@ -28,7 +29,6 @@ The following tables depend on gcp_bigquery_datasets:
 |description|String|
 |etag|String|
 |friendly_name|String|
-|id|String|
 |is_case_insensitive|Bool|
 |kind|String|
 |labels|JSON|
diff --git a/plugins/source/gcp/resources/services/bigquery/datasets.go b/plugins/source/gcp/resources/services/bigquery/datasets.go
@@ -20,6 +20,17 @@ func Datasets() *schema.Table {
 				Name:     "project_id",
 				Type:     schema.TypeString,
 				Resolver: client.ResolveProject,
+				CreationOptions: schema.ColumnCreationOptions{
+					PrimaryKey: true,
+				},
+			},
+			{
+				Name:     "id",
+				Type:     schema.TypeString,
+				Resolver: schema.PathResolver("Id"),
+				CreationOptions: schema.ColumnCreationOptions{
+					PrimaryKey: true,
+				},
 			},
 		},
 		Relations: []*schema.Table{
