Skip to content

Commit f31ece8

Browse files
disqdisq
authored
feat(aws): Use PreResourceResolver to resolve list/describe resources (#2461)
Shouldn't change performance as we don't have the proposed "PreResourceResolver parallelism" in the plugin-sdk yet.
1 parent 4c90daa commit f31ece8

File tree

89 files changed

+1030
-730
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

89 files changed

+1030
-730
lines changed

‎plugins/source/aws/codegen/recipes/backup.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@ func BackupResources() []*Resource {
2323
},
2424
},
2525
{
26-
SubService: "plans",
27-
Struct: &backup.GetBackupPlanOutput{},
28-
SkipFields: []string{"BackupPlanArn"},
26+
SubService: "plans",
27+
Struct: &backup.GetBackupPlanOutput{},
28+
SkipFields: []string{"BackupPlanArn"},
29+
PreResourceResolver: "getPlan",
2930
ExtraColumns: append(
3031
defaultRegionalColumns,
3132
[]codegen.ColumnDefinition{

‎plugins/source/aws/codegen/recipes/cloudfront.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@ func CloudfrontResources() []*Resource {
2424
}...),
2525
},
2626
{
27-
SubService: "distributions",
28-
Struct: &types.Distribution{},
29-
SkipFields: []string{"ARN"},
27+
SubService: "distributions",
28+
Struct: &types.Distribution{},
29+
SkipFields: []string{"ARN"},
30+
PreResourceResolver: "getDistribution",
3031
ExtraColumns: append(
3132
defaultAccountColumns,
3233
[]codegen.ColumnDefinition{

‎plugins/source/aws/codegen/recipes/cognito.go‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ import (
1010
func CognitoResources() []*Resource {
1111
resources := []*Resource{
1212
{
13-
SubService: "identity_pools",
14-
Struct: &cognitoidentity.DescribeIdentityPoolOutput{},
15-
SkipFields: []string{"IdentityPoolId"},
13+
SubService: "identity_pools",
14+
Struct: &cognitoidentity.DescribeIdentityPoolOutput{},
15+
SkipFields: []string{"IdentityPoolId"},
16+
PreResourceResolver: "getIdentityPool",
1617
ExtraColumns: []codegen.ColumnDefinition{
1718
{
1819
Name: "account_id",
@@ -40,9 +41,10 @@ func CognitoResources() []*Resource {
4041
},
4142
},
4243
{
43-
SubService: "user_pools",
44-
Struct: &types.UserPoolType{},
45-
SkipFields: []string{"Id"},
44+
SubService: "user_pools",
45+
Struct: &types.UserPoolType{},
46+
SkipFields: []string{"Id"},
47+
PreResourceResolver: "getUserPool",
4648
ExtraColumns: []codegen.ColumnDefinition{
4749
{
4850
Name: "account_id",
@@ -68,9 +70,10 @@ func CognitoResources() []*Resource {
6870
},
6971
},
7072
{
71-
SubService: "user_pool_identity_providers",
72-
Struct: &types.IdentityProviderType{},
73-
SkipFields: []string{},
73+
SubService: "user_pool_identity_providers",
74+
Struct: &types.IdentityProviderType{},
75+
SkipFields: []string{},
76+
PreResourceResolver: "getUserPoolIdentityProvider",
7477
ExtraColumns: append(
7578
defaultRegionalColumns,
7679
[]codegen.ColumnDefinition{

‎plugins/source/aws/codegen/recipes/dynamodb.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@ import (
99
func DynamoDBResources() []*Resource {
1010
resources := []*Resource{
1111
{
12-
SubService: "tables",
13-
Struct: &types.TableDescription{},
14-
SkipFields: []string{"TableArn"},
12+
SubService: "tables",
13+
Struct: &types.TableDescription{},
14+
SkipFields: []string{"TableArn"},
15+
PreResourceResolver: "getTable",
1516
ExtraColumns: append(
1617
defaultRegionalColumns,
1718
[]codegen.ColumnDefinition{

‎plugins/source/aws/codegen/recipes/elasticsearch.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@ import (
99
func ElasticsearchResources() []*Resource {
1010
resources := []*Resource{
1111
{
12-
SubService: "domains",
13-
Struct: &types.ElasticsearchDomainStatus{},
14-
SkipFields: []string{"DomainId"},
12+
SubService: "domains",
13+
Struct: &types.ElasticsearchDomainStatus{},
14+
SkipFields: []string{"DomainId"},
15+
PreResourceResolver: "getDomain",
1516
ExtraColumns: []codegen.ColumnDefinition{
1617
{
1718
Name: "account_id",

‎plugins/source/aws/codegen/recipes/glue.go‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,10 @@ func GlueResources() []*Resource {
284284
},
285285
},
286286
{
287-
SubService: "registry_schemas",
288-
Struct: &glue.GetSchemaOutput{},
289-
SkipFields: []string{"SchemaArn"},
287+
SubService: "registry_schemas",
288+
Struct: &glue.GetSchemaOutput{},
289+
SkipFields: []string{"SchemaArn"},
290+
PreResourceResolver: "getRegistrySchema",
290291
ExtraColumns: append(
291292
defaultRegionalColumns,
292293
[]codegen.ColumnDefinition{
@@ -306,9 +307,10 @@ func GlueResources() []*Resource {
306307
},
307308
},
308309
{
309-
SubService: "registry_schema_versions",
310-
Struct: &glue.GetSchemaVersionOutput{},
311-
SkipFields: []string{},
310+
SubService: "registry_schema_versions",
311+
Struct: &glue.GetSchemaVersionOutput{},
312+
SkipFields: []string{},
313+
PreResourceResolver: "getRegistrySchemaVersion",
312314
ExtraColumns: append(
313315
defaultRegionalColumns,
314316
[]codegen.ColumnDefinition{
@@ -369,9 +371,10 @@ func GlueResources() []*Resource {
369371
}...),
370372
},
371373
{
372-
SubService: "workflows",
373-
Struct: &types.Workflow{},
374-
SkipFields: []string{},
374+
SubService: "workflows",
375+
Struct: &types.Workflow{},
376+
SkipFields: []string{},
377+
PreResourceResolver: "getWorkflow",
375378
ExtraColumns: append(
376379
defaultRegionalColumns,
377380
[]codegen.ColumnDefinition{

‎plugins/source/aws/codegen/recipes/guardduty.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ import (
1313
func GuarddutyResources() []*Resource {
1414
resources := []*Resource{
1515
{
16-
SubService: "detectors",
17-
Struct: &models.DetectorWrapper{},
18-
SkipFields: []string{"Id"},
16+
SubService: "detectors",
17+
Struct: &models.DetectorWrapper{},
18+
SkipFields: []string{"Id"},
19+
PreResourceResolver: "getDetector",
1920
ExtraColumns: []codegen.ColumnDefinition{
2021
{
2122
Name: "account_id",

‎plugins/source/aws/codegen/recipes/iam.go‎

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,10 @@ func IAMResources() []*Resource {
129129
Relations: []string{"GroupPolicies()"},
130130
},
131131
{
132-
SubService: "group_policies",
133-
Struct: &iam.GetGroupPolicyOutput{},
134-
SkipFields: []string{"PolicyDocument"},
132+
SubService: "group_policies",
133+
Struct: &iam.GetGroupPolicyOutput{},
134+
SkipFields: []string{"PolicyDocument"},
135+
PreResourceResolver: "getGroupPolicy",
135136
ExtraColumns: append(
136137
defaultAccountColumns,
137138
[]codegen.ColumnDefinition{
@@ -153,9 +154,10 @@ func IAMResources() []*Resource {
153154
}...),
154155
},
155156
{
156-
SubService: "openid_connect_identity_providers",
157-
Struct: &models.IamOpenIdIdentityProviderWrapper{},
158-
SkipFields: []string{"Arn", "Tags"},
157+
SubService: "openid_connect_identity_providers",
158+
Struct: &models.IamOpenIdIdentityProviderWrapper{},
159+
SkipFields: []string{"Arn", "Tags"},
160+
PreResourceResolver: "getOpenIdConnectIdentityProvider",
159161
ExtraColumns: append(
160162
defaultAccountColumns,
161163
[]codegen.ColumnDefinition{
@@ -251,9 +253,10 @@ func IAMResources() []*Resource {
251253
},
252254
},
253255
{
254-
SubService: "role_policies",
255-
Struct: &iam.GetRolePolicyOutput{},
256-
SkipFields: []string{"PolicyDocument"},
256+
SubService: "role_policies",
257+
Struct: &iam.GetRolePolicyOutput{},
258+
SkipFields: []string{"PolicyDocument"},
259+
PreResourceResolver: "getRolePolicy",
257260
ExtraColumns: append(
258261
defaultAccountColumns,
259262
[]codegen.ColumnDefinition{
@@ -270,9 +273,10 @@ func IAMResources() []*Resource {
270273
}...),
271274
},
272275
{
273-
SubService: "saml_identity_providers",
274-
Struct: &types.SAMLProviderListEntry{},
275-
SkipFields: []string{"Arn", "Tags"},
276+
SubService: "saml_identity_providers",
277+
Struct: &types.SAMLProviderListEntry{},
278+
SkipFields: []string{"Arn", "Tags"},
279+
PreResourceResolver: "getSamlIdentityProvider",
276280
ExtraColumns: append(
277281
defaultAccountColumns,
278282
[]codegen.ColumnDefinition{
@@ -409,9 +413,10 @@ func IAMResources() []*Resource {
409413
}...),
410414
},
411415
{
412-
SubService: "user_policies",
413-
Struct: &iam.GetUserPolicyOutput{},
414-
SkipFields: []string{"PolicyDocument"},
416+
SubService: "user_policies",
417+
Struct: &iam.GetUserPolicyOutput{},
418+
SkipFields: []string{"PolicyDocument"},
419+
PreResourceResolver: "getUserPolicy",
415420
ExtraColumns: append(
416421
defaultAccountColumns,
417422
[]codegen.ColumnDefinition{

‎plugins/source/aws/codegen/recipes/lambda.go‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@ import (
1414
func LambdaResources() []*Resource {
1515
resources := []*Resource{
1616
{
17-
SubService: "functions",
18-
Struct: &lambda.GetFunctionOutput{},
19-
SkipFields: []string{},
17+
SubService: "functions",
18+
Struct: &lambda.GetFunctionOutput{},
19+
SkipFields: []string{},
20+
PreResourceResolver: "getFunction",
2021
ExtraColumns: append(
2122
defaultRegionalColumns,
2223
[]codegen.ColumnDefinition{
@@ -67,9 +68,10 @@ func LambdaResources() []*Resource {
6768
}...),
6869
},
6970
{
70-
SubService: "function_aliases",
71-
Struct: &models.AliasWrapper{},
72-
SkipFields: []string{"AliasArn"},
71+
SubService: "function_aliases",
72+
Struct: &models.AliasWrapper{},
73+
SkipFields: []string{"AliasArn"},
74+
PreResourceResolver: "getFunctionAliasURLConfig",
7375
ExtraColumns: append(
7476
defaultRegionalColumns,
7577
[]codegen.ColumnDefinition{

‎plugins/source/aws/codegen/recipes/mq.go‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ import (
1010
func MQResources() []*Resource {
1111
resources := []*Resource{
1212
{
13-
SubService: "brokers",
14-
Struct: &mq.DescribeBrokerOutput{},
15-
SkipFields: []string{"BrokerArn"},
13+
SubService: "brokers",
14+
Struct: &mq.DescribeBrokerOutput{},
15+
SkipFields: []string{"BrokerArn"},
16+
PreResourceResolver: "getMqBroker",
1617
ExtraColumns: append(
1718
defaultRegionalColumns,
1819
[]codegen.ColumnDefinition{
@@ -46,9 +47,10 @@ func MQResources() []*Resource {
4647
},
4748
},
4849
{
49-
SubService: "broker_configuration_revisions",
50-
Struct: &mq.DescribeConfigurationRevisionOutput{},
51-
SkipFields: []string{"Data"},
50+
SubService: "broker_configuration_revisions",
51+
Struct: &mq.DescribeConfigurationRevisionOutput{},
52+
SkipFields: []string{"Data"},
53+
PreResourceResolver: "getMqBrokerConfigurationRevision",
5254
ExtraColumns: append(
5355
defaultRegionalColumns,
5456
[]codegen.ColumnDefinition{

0 commit comments

Comments
 (0)