fix: Call list tables once on insert if --no-migrate was used (#13327)

erezrokah · web-flow · commit eda215c0d204 · 2023-08-25T12:33:25.000Z
#### Summary Follow up to #13323 to handle `--no-migrate`. Thanks @candiduslynx for pointing it out <!--
diff --git a/plugins/destination/postgresql/client/client.go b/plugins/destination/postgresql/client/client.go
@@ -43,8 +43,7 @@ const (
 
 func New(ctx context.Context, logger zerolog.Logger, specBytes []byte, opts plugin.NewClientOptions) (plugin.Client, error) {
 	c := &Client{
-		logger:                  logger.With().Str("module", "pg-dest").Logger(),
-		pgTablesToPKConstraints: make(map[string]string),
+		logger: logger.With().Str("module", "pg-dest").Logger(),
 	}
 	if opts.NoConnection {
 		return c, nil
diff --git a/plugins/destination/postgresql/client/insert.go b/plugins/destination/postgresql/client/insert.go
@@ -20,6 +20,15 @@ func (c *Client) InsertBatch(ctx context.Context, messages message.WriteInserts)
 		return err
 	}
 
+	// This happens when the CLI was invoked with `sync --no-migrate`
+	if c.pgTablesToPKConstraints == nil {
+		// Passing nil for include and exclude lists all tables and populates c.pgTablesToPKConstraints
+		_, err := c.listTables(ctx, nil, nil)
+		if err != nil {
+			return err
+		}
+	}
+
 	tables = c.normalizeTables(tables)
 	if err != nil {
 		return err
diff --git a/plugins/destination/postgresql/client/list_tables.go b/plugins/destination/postgresql/client/list_tables.go
@@ -63,6 +63,7 @@ ORDER BY
 `
 
 func (c *Client) listTables(ctx context.Context, include, exclude []string) (schema.Tables, error) {
+	c.pgTablesToPKConstraints = map[string]string{}
 	var tables schema.Tables
 	whereClause := c.whereClause(include, exclude)
 	if c.pgType == pgTypeCockroachDB {

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,7 @@ const (`
`43`	`43`
`44`	`44`	`func New(ctx context.Context, logger zerolog.Logger, specBytes []byte, opts plugin.NewClientOptions) (plugin.Client, error) {`
`45`	`45`	`c := &Client{`
`46`		`- logger: logger.With().Str("module", "pg-dest").Logger(),`
`47`		`- pgTablesToPKConstraints: make(map[string]string),`
	`46`	`+ logger: logger.With().Str("module", "pg-dest").Logger(),`
`48`	`47`	`}`
`49`	`48`	`if opts.NoConnection {`
`50`	`49`	`return c, nil`
Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ ORDER BY`
`63`	`63`	`
`64`	`64`
`65`	`65`	`func (c *Client) listTables(ctx context.Context, include, exclude []string) (schema.Tables, error) {`
	`66`	`+ c.pgTablesToPKConstraints = map[string]string{}`
`66`	`67`	`var tables schema.Tables`
`67`	`68`	`whereClause := c.whereClause(include, exclude)`
`68`	`69`	`if c.pgType == pgTypeCockroachDB {`