fix(aws-codegen): Check error returned by formatAndWriteFile (#5793)

hermanschaaf · web-flow · commit ed0d9d78ffe5 · 2022-12-19T11:49:05.000Z
This error was not being checked and could be hiding errors from the codegen user.
diff --git a/plugins/source/aws/codegen/services/generate.go b/plugins/source/aws/codegen/services/generate.go
@@ -13,7 +13,7 @@ import (
 	"strings"
 	"text/template"
 
-	caser "github.com/cloudquery/plugin-sdk/caser"
+	"github.com/cloudquery/plugin-sdk/caser"
 )
 
 //go:embed templates/*.go.tpl
@@ -156,7 +156,10 @@ func Generate() error {
 			return fmt.Errorf("failed to execute template: %w", err)
 		}
 		filePath := path.Join(path.Dir(filename), fmt.Sprintf("../../client/services/%s.go", service.PackageName))
-		formatAndWriteFile(filePath, buff)
+		err := formatAndWriteFile(filePath, buff)
+		if err != nil {
+			return fmt.Errorf("failed to format and write file for service %v: %w", service.Name, err)
+		}
 	}
 
 	for _, custom := range customClients {

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ import (`
`13`	`13`	`"strings"`
`14`	`14`	`"text/template"`
`15`	`15`
`16`		`- caser "github.com/cloudquery/plugin-sdk/caser"`
	`16`	`+ "github.com/cloudquery/plugin-sdk/caser"`
`17`	`17`	`)`
`18`	`18`
`19`	`19`	`//go:embed templates/*.go.tpl`
`@@ -156,7 +156,10 @@ func Generate() error {`
`156`	`156`	`return fmt.Errorf("failed to execute template: %w", err)`
`157`	`157`	`}`
`158`	`158`	`filePath := path.Join(path.Dir(filename), fmt.Sprintf("../../client/services/%s.go", service.PackageName))`
`159`		`- formatAndWriteFile(filePath, buff)`
	`159`	`+ err := formatAndWriteFile(filePath, buff)`
	`160`	`+ if err != nil {`
	`161`	`+ return fmt.Errorf("failed to format and write file for service %v: %w", service.Name, err)`
	`162`	`+ }`
`160`	`163`	`}`
`161`	`164`
`162`	`165`	`for _, custom := range customClients {`