fix(gcp-resources): Add project_id as PK of gcp_logging_sinks (#6545)

erezrokah · web-flow · commit d183b519b3a0 · 2023-01-09T19:30:53.000Z
#### Summary Similar to #6544, sink names are unique within a project: ```go // Required. The client-assigned sink identifier, unique within the project. // // For example: `"my-syslog-errors-to-pubsub"`. Sink identifiers are limited // to 100 characters and can include only the following characters: upper and // lower-case alphanumeric characters, underscores, hyphens, and periods. // First character has to be alphanumeric. Name string `protobuf:"bytes,1,opt,name=name,proto3" json:"name,omitempty"` ``` <!--
diff --git a/plugins/source/gcp/docs/tables/gcp_logging_sinks.md b/plugins/source/gcp/docs/tables/gcp_logging_sinks.md
@@ -2,7 +2,7 @@
 
 https://cloud.google.com/logging/docs/reference/v2/rest/v2/projects.sinks#LogSink
 
-The primary key for this table is **name**.
+The composite primary key for this table is (**project_id**, **name**).
 
 ## Columns
 
@@ -12,7 +12,7 @@ The primary key for this table is **name**.
 |_cq_sync_time|Timestamp|
 |_cq_id|UUID|
 |_cq_parent_id|UUID|
-|project_id|String|
+|project_id (PK)|String|
 |name (PK)|String|
 |destination|String|
 |filter|String|
diff --git a/plugins/source/gcp/resources/services/logging/sinks.go b/plugins/source/gcp/resources/services/logging/sinks.go
@@ -25,6 +25,9 @@ func Sinks() *schema.Table {
 				Name:     "project_id",
 				Type:     schema.TypeString,
 				Resolver: client.ResolveProject,
+				CreationOptions: schema.ColumnCreationOptions{
+					PrimaryKey: true,
+				},
 			},
 			{
 				Name:     "name",
