fix: Only validate version when Cloudquery Registry is used (#20459)

bbernays · web-flow · commit b45dfb761c6d · 2025-03-31T14:47:29.000Z
#### Summary ⚠️ **If you're contributing to a plugin please read this section of the [contribution guidelines](https://github.com/cloudquery/cloudquery/blob/main/CONTRIBUTING.md#open-core-vs-open-source) 🧑‍🎓 before submitting this PR** ⚠️
diff --git a/cli/internal/specs/v0/version.go b/cli/internal/specs/v0/version.go
@@ -23,7 +23,10 @@ func WarnOnOutdatedVersions(ctx context.Context, p *managedplugin.PluginVersionW
 			continue
 		}
 		// N.B.: warning is best-effort; we ignore errors, but the function still logs errors with Debug logs
-		_, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginSource.String(), source.Version)
+		// We only check for outdated plugins if the registry is cloudquery or github and the org is cloudquery
+		if source.Registry == RegistryCloudQuery || (source.Registry == RegistryGitHub && org == "cloudquery") {
+			_, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginSource.String(), source.Version)
+		}
 	}
 	for _, destination := range destinations {
 		org, name, err := pluginPathToOrgName(destination.Path)
@@ -32,7 +35,10 @@ func WarnOnOutdatedVersions(ctx context.Context, p *managedplugin.PluginVersionW
 			continue
 		}
 		// N.B.: warning is best-effort; we ignore errors, but the function still logs errors with Debug logs
-		_, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginDestination.String(), destination.Version)
+		// We only check for outdated plugins if the registry is cloudquery or github and the org is cloudquery
+		if destination.Registry == RegistryCloudQuery || (destination.Registry == RegistryGitHub && org == "cloudquery") {
+			_, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginDestination.String(), destination.Version)
+		}
 	}
 	for _, transformer := range transformers {
 		org, name, err := pluginPathToOrgName(transformer.Path)
@@ -41,7 +47,10 @@ func WarnOnOutdatedVersions(ctx context.Context, p *managedplugin.PluginVersionW
 			continue
 		}
 		// N.B.: warning is best-effort; we ignore errors, but the function still logs errors with Debug logs
-		_, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginTransformer.String(), transformer.Version)
+		// We only check for outdated plugins if the registry is cloudquery or github and the org is cloudquery
+		if transformer.Registry == RegistryCloudQuery || (transformer.Registry == RegistryGitHub && org == "cloudquery") {
+			_, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginTransformer.String(), transformer.Version)
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,10 @@ func WarnOnOutdatedVersions(ctx context.Context, p *managedplugin.PluginVersionW`
`23`	`23`	`continue`
`24`	`24`	`}`
`25`	`25`	`// N.B.: warning is best-effort; we ignore errors, but the function still logs errors with Debug logs`
`26`		`- _, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginSource.String(), source.Version)`
	`26`	`+ // We only check for outdated plugins if the registry is cloudquery or github and the org is cloudquery`
	`27`	`+ if source.Registry == RegistryCloudQuery \|\| (source.Registry == RegistryGitHub && org == "cloudquery") {`
	`28`	`+ _, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginSource.String(), source.Version)`
	`29`	`+ }`
`27`	`30`	`}`
`28`	`31`	`for _, destination := range destinations {`
`29`	`32`	`org, name, err := pluginPathToOrgName(destination.Path)`
`@@ -32,7 +35,10 @@ func WarnOnOutdatedVersions(ctx context.Context, p *managedplugin.PluginVersionW`
`32`	`35`	`continue`
`33`	`36`	`}`
`34`	`37`	`// N.B.: warning is best-effort; we ignore errors, but the function still logs errors with Debug logs`
`35`		`- _, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginDestination.String(), destination.Version)`
	`38`	`+ // We only check for outdated plugins if the registry is cloudquery or github and the org is cloudquery`
	`39`	`+ if destination.Registry == RegistryCloudQuery \|\| (destination.Registry == RegistryGitHub && org == "cloudquery") {`
	`40`	`+ _, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginDestination.String(), destination.Version)`
	`41`	`+ }`
`36`	`42`	`}`
`37`	`43`	`for _, transformer := range transformers {`
`38`	`44`	`org, name, err := pluginPathToOrgName(transformer.Path)`
`@@ -41,7 +47,10 @@ func WarnOnOutdatedVersions(ctx context.Context, p *managedplugin.PluginVersionW`
`41`	`47`	`continue`
`42`	`48`	`}`
`43`	`49`	`// N.B.: warning is best-effort; we ignore errors, but the function still logs errors with Debug logs`
`44`		`- _, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginTransformer.String(), transformer.Version)`
	`50`	`+ // We only check for outdated plugins if the registry is cloudquery or github and the org is cloudquery`
	`51`	`+ if transformer.Registry == RegistryCloudQuery \|\| (transformer.Registry == RegistryGitHub && org == "cloudquery") {`
	`52`	`+ _, _ = p.WarnIfOutdated(ctx, org, name, managedplugin.PluginTransformer.String(), transformer.Version)`
	`53`	`+ }`
`45`	`54`	`}`
`46`	`55`	`}`
`47`	`56`